-
Notifications
You must be signed in to change notification settings - Fork 645
Split LogRequests
middleware into multiple middlewares
#3898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32274e1
to
b5cbc76
Compare
☔ The latest upstream changes (presumably #3904) made this pull request unmergeable. Please resolve the merge conflicts. |
5b0f4d9
to
c2cca5a
Compare
9a28d52
to
2a10ef7
Compare
5e2022e
to
513e490
Compare
513e490
to
bf42280
Compare
☔ The latest upstream changes (presumably #3988) made this pull request unmergeable. Please resolve the merge conflicts. |
bf42280
to
1d10d25
Compare
1d10d25
to
113b485
Compare
☔ The latest upstream changes (presumably #4036) made this pull request unmergeable. Please resolve the merge conflicts. |
closing in favor of #4137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-backend ⚙️
C-internal 🔧
Category: Nonessential work that would make the codebase more consistent or clear
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LogRequests
middleware is currently performing multiple tasks:req.path()
before theNormalizePath
middleware potentially mutates the request pathx-request-start
HTTP header from Heroku (or theStartInstant
extension as a fallback)The Sentry error reporting was originally built into the
LogRequests
middleware because it also needed access to the original path and the response timing.This PR proposes to split the
LogRequests
middleware, so that each middlewares is performing only one of the functions respectively:NormalizePath
middleware that is responsible for mutating the path in the first placeRequestTiming
middleware, which saves the response time in the request extension mapSentryMiddleware