middleware::LogRequests: Extract Sentry setup into dedicated middleware struct #4137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
|
☔ The latest upstream changes (presumably #4143) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
sentry-middleware
branch
from
486bc47 to
73a26d0
Compare
Turbo87
force-pushed
the
sentry-middleware
branch
from
73a26d0 to
0c1bebf
Compare
|
@bors r+ |
|
📌 Commit 0c1bebf has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LogRequestsshould be responsible for logging the requests, but nothing more. This PR extracts the custom Sentry code from it and moves it into a dedicated middleware, that wraps thesentry-conduitmiddleware.