Skip to content

change URLs in releases-pages to remove unnecessary redirect #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

syphar
Copy link
Member

@syphar syphar commented Jan 20, 2021

stumbled on this while testing around.

The release-pages link to the docs without the trailing /, and the rustdoc page then appends the / with a redirect.

Not not any more

@jyn514
Copy link
Member

jyn514 commented Jan 21, 2021

Looks like you need to update the tests:

 thread 'web::releases::tests::releases_homepage_and_recent' panicked at 'assertion failed: `(left == right)`
  left: `"/crate_that_succeeded_with_github/0.2.0/crate_that_succeeded_with_github/"`,
 right: `"/crate_that_succeeded_with_github/0.2.0/crate_that_succeeded_with_github"`', src/web/releases.rs:1238:17

Looks fine other than that, though :)

@jyn514 jyn514 added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jan 21, 2021
@syphar
Copy link
Member Author

syphar commented Jan 21, 2021

@jyn514 damnit, the one time I don't run them locally 😆

@syphar
Copy link
Member Author

syphar commented Jan 21, 2021

updated them now

@syphar
Copy link
Member Author

syphar commented Jan 21, 2021

also rebased on master, to fixed the last test failure

@jyn514 jyn514 merged commit 5d40f1d into rust-lang:master Jan 21, 2021
@jyn514 jyn514 added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jan 21, 2021
@syphar syphar deleted the less-redirects branch January 21, 2021 18:02
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants