Skip to content

change URLs in releases-pages to remove unnecessary redirect #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2021
Merged

change URLs in releases-pages to remove unnecessary redirect #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2291e0d
change URLs in releases-pages to remove unnecessary redirect
syphar Jan 20, 2021
2188c77
fix tests for changed release page links
syphar Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/web/releases.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,7 +1166,7 @@ mod tests {
assert_eq!(links.len(), 2);
assert_eq!(
links[0],
"/crate_that_succeeded_with_github/0.2.0/crate_that_succeeded_with_github"
"/crate_that_succeeded_with_github/0.2.0/crate_that_succeeded_with_github/"
);
assert_eq!(links[1], "/crate/crate_that_failed_with_github/0.1.0");

Expand Down Expand Up @@ -1277,7 +1277,7 @@ mod tests {
assert_eq!(links[0], "/crate/crate_that_failed/0.1.0");
assert_eq!(
links[1],
"/crate_that_succeeded_with_github/0.2.0/crate_that_succeeded_with_github"
"/crate_that_succeeded_with_github/0.2.0/crate_that_succeeded_with_github/"
);
}

Expand Down
2 changes: 1 addition & 1 deletion templates/core/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ <h1 class="brand">{{ "cubes" | fas(fw=true) }} Docs.rs</h1>
<ul>
{%- for release in recent_releases -%}
{%- if release.rustdoc_status -%}
{%- set release_url = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name -%}
{%- set release_url = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name ~ "/" -%}
{%- else -%}
{%- set release_url = "/crate/" ~ release.name ~ "/" ~ release.version -%}
{%- endif -%}
Expand Down
2 changes: 1 addition & 1 deletion templates/releases/feed.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

{%- for release in recent_releases -%}
{%- if release.rustdoc_status -%}
{%- set link = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name -%}
{%- set link = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name ~ "/" -%}
{%- else -%}
{%- set link = "/crate/" ~ release.name ~ "/" ~ release.version -%}
{%- endif %}
Expand Down
2 changes: 1 addition & 1 deletion templates/releases/releases.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
{# TODO: If there are no releases, then display a message that says so #}
{%- for release in releases -%}
{%- if release.rustdoc_status -%}
{% set link = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name -%}
{% set link = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name ~ "/" -%}
{%- else -%}
{% set link = "/crate/" ~ release.name ~ "/" ~ release.version -%}
{%- endif -%}
Expand Down