Add some keyboard interactions with the website first pages #324
Conversation
| @@ -31,6 +54,59 @@ | |||
| <div class="release"> | |||
| <a href="/releases"><strong>Recent Releases</strong></a> <a href="/releases/feed" title="Atom feed"><i class="fa fa-rss-square"></i></a> | |||
| </div> | |||
| {{else}} | |||
There was a problem hiding this comment.
Why is the JS that registers the key handlers in the else branch of the template? Wouldn't that make it not appear on the front page?
There was a problem hiding this comment.
That's the whole point! I want to be able to navigate through my search results, not on the front page.
There was a problem hiding this comment.
But doesn't this also register the "S" shortcut?
There was a problem hiding this comment.
No, the "S" shortcut is "registered" through handleShortcut whereas the up and down arrows are "registered" through handleKey.
There was a problem hiding this comment.
Aha, i see it now. I was confused because this also registered "S", but that's probably because the handler overwrites document.onkeypress/document.onkeydown. This looks fine, then.
It'd be nice to navigate using the keyboard only on the first pages (on the crates pages, I prefer to not touch them by adding new shortcuts for the moment).
If someone could double-check too, it'd be very appreciated. :)