fix keyboard nav on releases pages #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
requested changes
Apr 11, 2019
| @@ -62,15 +62,15 @@ | |||
| if (ev.ctrlKey || ev.altKey || ev.metaKey || document.activeElement.tagName === "INPUT") { | |||
| return; | |||
| } | |||
| if (ev.which === 38) { // Down arrow | |||
| if (ev.which === 40) { // Down arrow | |||
| if (active === null) { | |||
There was a problem hiding this comment.
You need to add ev.preventDefault().
| if (active === null) { | ||
| active = document.getElementsByClassName("recent-releases-container")[0].getElementsByTagName("li")[0]; | ||
| } else if (active.nextElementSibling) { | ||
| active.classList.remove("selected"); | ||
| active = active.nextElementSibling; | ||
| } | ||
| active.classList.add("selected"); | ||
| } else if (ev.which === 40) { // Up arrow | ||
| } else if (ev.which === 38) { // Up arrow | ||
| if (active === null) { |
There was a problem hiding this comment.
You need to add ev.preventDefault().
|
Tested on dev server and it works, merging and deploying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deploying #324 and testing it out, it looks like @GuillaumeGomez got the arrow keys backwards. This switches them around and makes it work properly.