Skip to content

fix keyboard nav on releases pages #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions templates/releases.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,17 @@
if (ev.ctrlKey || ev.altKey || ev.metaKey || document.activeElement.tagName === "INPUT") {
return;
}
if (ev.which === 38) { // Down arrow
if (ev.which === 40) { // Down arrow
ev.preventDefault();
if (active === null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add ev.preventDefault().

active = document.getElementsByClassName("recent-releases-container")[0].getElementsByTagName("li")[0];
} else if (active.nextElementSibling) {
active.classList.remove("selected");
active = active.nextElementSibling;
}
active.classList.add("selected");
} else if (ev.which === 40) { // Up arrow
} else if (ev.which === 38) { // Up arrow
ev.preventDefault();
if (active === null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add ev.preventDefault().

active = document.getElementsByClassName("recent-releases-container")[0].getElementsByTagName("li")[0];
} else if (active.previousElementSibling) {
Expand All @@ -79,7 +81,7 @@
}
active.classList.add("selected");
active.focus();
} else if (e.which === 13) { // Return
} else if (ev.which === 13) { // Return
if (active !== null) {
document.location.href = active.getElementsByTagName("a")[0].href;
}
Expand Down