Skip to content

Fix panics when viewing source of failed build (redux) #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 16, 2019

This reverts all the changes from #519 except for actually fixing the panic. I tested this with directory listings as well as individual files:

  • If no files exist, gives a 200 with an empty page (not ideal but better than the panic + blank screen from before). This can be tested with e.g. pam-sys 1.0.0-alpha1.
  • If a directory listing exists, show that. Can be tested with most crates, e.g. rand 0.7.2.
  • If a file exists, show that (no logic changed)

r? @pietroalbini

@pietroalbini
Copy link
Member

Can we still show a not found page when None is returned?

@jyn514
Copy link
Member Author

jyn514 commented Dec 19, 2019

I think this only shows a 404 for binaries and not libraries, but I'd appreciate you testing locally too after last time 😆

@pietroalbini pietroalbini self-assigned this Dec 19, 2019
@pietroalbini
Copy link
Member

This looks great!

@pietroalbini pietroalbini merged commit d22b68b into rust-lang:master Dec 27, 2019
@jyn514 jyn514 deleted the panic-source branch December 27, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants