Skip to content

Fix panics when viewing source of failed build (redux) #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2019
Merged

Fix panics when viewing source of failed build (redux) #526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e50873
revert all the changes except for fixing the panic
jyn514 Dec 15, 2019
9f35100
show 404 when None is returned
jyn514 Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/web/source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ impl FileList {
return None;
}

let files: Json = rows.get(0).get(5);
let files: Json = rows.get(0).get_opt(5).unwrap().ok()?;

let mut file_list: Vec<File> = Vec::new();

Expand Down Expand Up @@ -234,6 +234,11 @@ pub fn source_browser_handler(req: &mut Request) -> IronResult<Response> {
};

let list = FileList::from_path(&conn, &name, &version, &req_path);
if list.is_none() {
use iron::status;
use super::error::Nope;
return Err(IronError::new(Nope::NoResults, status::NotFound));
}

let page = Page::new(list)
.set_bool("show_parent_link", !req_path.is_empty())
Expand Down