Skip to content

minor: Optimizing Performance with Promise.all 🏎 #16162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

sanjaiyan-dev
Copy link
Contributor

Hello,

This pull request introduces a modest performance improvement by executing asynchronous tasks using Promise.all, thereby enhancing the efficient utilization of hardware resources.

Thank you for considering this enhancement.

Ref-: rust-lang/rust#119108

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 19, 2023
@lnicola
Copy link
Member

lnicola commented Dec 19, 2023

Thanks, although this is not going to matter in practice and it's a non-default configuration.

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2023

📌 Commit f587b54 has been approved by lnicola

It is now in the queue for this repository.

@lnicola lnicola changed the title Optimizing Performance with Promise.all 🏎 minor: Optimizing Performance with Promise.all 🏎 Dec 19, 2023
@bors
Copy link
Contributor

bors commented Dec 19, 2023

⌛ Testing commit f587b54 with merge 245d529...

bors added a commit that referenced this pull request Dec 19, 2023
…icola

minor: Optimizing Performance with `Promise.all` 🏎

Hello,

This pull request introduces a modest performance improvement by executing asynchronous tasks using `Promise.all`, thereby enhancing the efficient utilization of hardware resources.

Thank you for considering this enhancement.

Ref-: rust-lang/rust#119108
@bors
Copy link
Contributor

bors commented Dec 19, 2023

💔 Test failed - checks-actions

@lnicola
Copy link
Member

lnicola commented Dec 19, 2023

@bors retry

@bors
Copy link
Contributor

bors commented Dec 19, 2023

⌛ Testing commit f587b54 with merge 831d0e0...

@bors
Copy link
Contributor

bors commented Dec 19, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 831d0e0 to master...

@bors bors merged commit 831d0e0 into rust-lang:master Dec 19, 2023
@sanjaiyan-dev sanjaiyan-dev deleted the sanjaiyan-async-concurrent branch December 19, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants