Skip to content

Optimizing Performance with Promise.all 🏎 #119108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Optimizing Performance with Promise.all 🏎 #119108

wants to merge 1 commit into from

Conversation

sanjaiyan-dev
Copy link
Contributor

Hello,

This pull request introduces a modest performance improvement by executing asynchronous tasks using Promise.all, thereby enhancing the efficient utilization of hardware resources.

Thank you for considering this enhancement.

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 19, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2023

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@Noratrieb
Copy link
Member

Hi! See the comment above, this PR should be filed against the rust-lang/rust-analyzer repository.

@sanjaiyan-dev sanjaiyan-dev mentioned this pull request Dec 19, 2023
Merged
@sanjaiyan-dev
Copy link
Contributor Author

Hi! See the comment above, this PR should be filed against the rust-lang/rust-analyzer repository.

Hi @Nilstrieb, Yh sorry for the inconvenience

Here is link to new PR -: rust-lang/rust-analyzer#16162

@Noratrieb Noratrieb closed this Dec 19, 2023
bors added a commit to rust-lang/rust-analyzer that referenced this pull request Dec 19, 2023
@bors
Auto merge of #16162 - sanjaiyan-dev:sanjaiyan-async-concurrent, r=ln…
245d529 
…icola

minor: Optimizing Performance with `Promise.all` 🏎

Hello,

This pull request introduces a modest performance improvement by executing asynchronous tasks using `Promise.all`, thereby enhancing the efficient utilization of hardware resources.

Thank you for considering this enhancement.

Ref-: rust-lang/rust#119108
bors added a commit to rust-lang/rust-analyzer that referenced this pull request Dec 19, 2023
@bors
Auto merge of #16162 - sanjaiyan-dev:sanjaiyan-async-concurrent, r=ln…
831d0e0 
…icola

minor: Optimizing Performance with `Promise.all` 🏎

Hello,

This pull request introduces a modest performance improvement by executing asynchronous tasks using `Promise.all`, thereby enhancing the efficient utilization of hardware resources.

Thank you for considering this enhancement.

Ref-: rust-lang/rust#119108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanjaiyan-dev @rustbot @Noratrieb @Mark-Simulacrum