`PatternError::StaticInPattern` seems to be dead code

[Centril]

https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_build/hair/pattern/struct.PatCtxt.html#method.report_inlining_errors never hits PatternError::StaticInPattern in practice it seems. We should check if it is actually unreachable.

cc @oli-obk

[JohnTitor]

Just checked that the removal doesn't affect any existing tests inside of this repo.

The relevant part:

rust/compiler/rustc_mir_build/src/thir/pattern/mod.rs

Lines 471 to 475 in d568d63

	self.errors.push(if is_associated_const {
	PatternError::AssocConstInPattern(span)
	} else {
	PatternError::StaticInPattern(span)
	});

The change will remove a pattern error if is_associated_const is false. But given we know DefKind is const or assoc const, it shouldn't be a problem?
@oli-obk Is that correct?

[oli-obk]

yes, we could still use the StaticInPattern error by adding an arm in

rust/compiler/rustc_mir_build/src/thir/pattern/mod.rs

Line 425 in d568d63

Res::Def(DefKind::ConstParam, _) => PatternError::ConstParamInPattern(span),

, which should then hopefully affect tests and improve diagnostics