Skip to content

Refactor PatternError structure #86460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2021

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Jun 19, 2021

Now we emit the StaticInPattern error precisely.
Fixes #68395
r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2021
@JohnTitor JohnTitor force-pushed the use-static-in-pattern-err branch from fd3bb71 to e44e65e Compare June 19, 2021 04:55
@oli-obk
Copy link
Contributor

oli-obk commented Jun 19, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 19, 2021

📌 Commit e44e65e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2021
@bors
Copy link
Collaborator

bors commented Jun 19, 2021

⌛ Testing commit e44e65e with merge 150fad3...

@bors
Copy link
Collaborator

bors commented Jun 19, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 150fad3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 19, 2021
@bors bors merged commit 150fad3 into rust-lang:master Jun 19, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 19, 2021
@JohnTitor JohnTitor deleted the use-static-in-pattern-err branch June 20, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PatternError::StaticInPattern seems to be dead code
5 participants