-
Notifications
You must be signed in to change notification settings - Fork 13.4k
add dropck_outlives
comments
#114170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add dropck_outlives
comments
#114170
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,16 +31,6 @@ impl<'tcx> super::QueryTypeOp<'tcx> for DropckOutlives<'tcx> { | |
tcx: TyCtxt<'tcx>, | ||
canonicalized: Canonical<'tcx, ParamEnvAnd<'tcx, Self>>, | ||
) -> Result<CanonicalQueryResponse<'tcx, Self::QueryResponse>, NoSolution> { | ||
// Subtle: note that we are not invoking | ||
// `infcx.at(...).dropck_outlives(...)` here, but rather the | ||
// underlying `dropck_outlives` query. This same underlying | ||
// query is also used by the | ||
// `infcx.at(...).dropck_outlives(...)` fn. Avoiding the | ||
// wrapper means we don't need an infcx in this code, which is | ||
// good because the interface doesn't give us one (so that we | ||
// know we are not registering any subregion relations or | ||
// other things). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
// FIXME convert to the type expected by the `dropck_outlives` | ||
// query. This should eventually be fixed by changing the | ||
// *underlying query*. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.