Skip to content

release notes: fix some incorrect CStr links #115115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

eric-seppanen
Copy link

A few links are incorrectly duplicated in the current draft of the release notes.

I'm not sure who to ask to get this looked at before the release goes out. @Mark-Simulacrum perhaps?

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 22, 2023
@bors
Copy link
Collaborator

bors commented Aug 23, 2023

☔ The latest upstream changes (presumably #115119) made this pull request unmergeable. Please resolve the merge conflicts.

@eric-seppanen
Copy link
Author

Already fixed in #115119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants