Skip to content

Update the links for Stabilized APIs in 1.72.0 #115119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

Update the links for Stabilized APIs in 1.72.0 #115119

merged 1 commit into from
Aug 23, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Aug 22, 2023

  • Use stable instead of nightly paths.
  • Fix the anchors for CStr::to_* links.

r? @Mark-Simulacrum

@cuviper
Update the links for Stabilized APIs in 1.72.0
42f993f 
* Use `stable` instead of `nightly` paths.
* Fix the anchors for `CStr::to_*` links.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 22, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup p=1

@bors
Copy link
Collaborator

bors commented Aug 23, 2023

📌 Commit 42f993f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2023
@bors
Copy link
Collaborator

bors commented Aug 23, 2023

⌛ Testing commit 42f993f with merge 6046aa0...

@bors
Copy link
Collaborator

bors commented Aug 23, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 6046aa0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2023
@bors bors merged commit 6046aa0 into rust-lang:master Aug 23, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 23, 2023
@bors bors mentioned this pull request Aug 23, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6046aa0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-2.9%, -1.8%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.977s -> 634.141s (-0.13%)
Artifact size: 347.14 MiB -> 347.08 MiB (-0.02%)

@cuviper cuviper deleted the relnotes-1.72-api branch August 25, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @Mark-Simulacrum @bors @rust-timer @rustbot