Skip to content

[beta] Clippy backport #127904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2024
Merged

[beta] Clippy backport #127904

merged 1 commit into from
Jul 20, 2024

Conversation

flip1995
Copy link
Member

r? @Mark-Simulacrum

Really small backport this time:

Fixes a quite annoying bug of this lint, that got into the last stable release 1.79.0. There were already 3 issues opened about it in the Clippy repo. It would be great to get this fixed for the next stable release.

I confirmed that this commit is already part of master

…efault, r=Alexendoo

Fix incorrect suggestion for `manual_unwrap_or_default`

Fixes rust-lang#12928.

If this not a "simple" pattern, better not emit the lint.

changelog: Fix incorrect suggestion for `manual_unwrap_or_default`
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Jul 20, 2024

📌 Commit db0c947 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2024
@bors
Copy link
Collaborator

bors commented Jul 20, 2024

⌛ Testing commit db0c947 with merge 7466ba0...

@bors
Copy link
Collaborator

bors commented Jul 20, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7466ba0 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2024
@bors bors merged commit 7466ba0 into rust-lang:beta Jul 20, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Jul 20, 2024
@flip1995 flip1995 deleted the clippy-beta-backport branch July 21, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants