Skip to content

rustdoc JSON: Don't apply #[repr] privacy heuristics #141126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmease
Copy link
Member

@fmease fmease commented May 17, 2025

Split out from #116882.
Context: #116882 (comment).
Partially reverts #138018.

cc @obi1kenobi
r? aDotInTheVoid or rustdoc

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

  • It's intentional.
  • The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

@bors

This comment was marked as resolved.

@aDotInTheVoid
Copy link
Member

r=me with merge-confixed fixed

@fmease fmease force-pushed the rev-rjson-priv-repr branch from d578819 to 98bd1a6 Compare May 22, 2025 19:27
@fmease
Copy link
Member Author

fmease commented May 22, 2025

@bors r=aDotInTheVoid rollup

@bors
Copy link
Collaborator

bors commented May 22, 2025

📌 Commit 98bd1a6 has been approved by aDotInTheVoid

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 23, 2025
…InTheVoid

rustdoc JSON: Don't apply `#[repr]` privacy heuristics

Split out from rust-lang#116882.
Context: rust-lang#116882 (comment).
Partially reverts rust-lang#138018.

cc `@obi1kenobi`
r? aDotInTheVoid or rustdoc
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136400 (Improve handling of rustdoc lints when used with raw doc fragments.)
 - rust-lang#140967 (Async drop poll shim for error dropee generates noop body)
 - rust-lang#141019 (Update std doctests for android)
 - rust-lang#141062 (Update IDEs to use rustfmt 2024, fix Zed settings)
 - rust-lang#141109 (discuss deadlocks in the std::io::pipe() example)
 - rust-lang#141126 (rustdoc JSON: Don't apply `#[repr]` privacy heuristics)
 - rust-lang#141376 (Rename `kw::Empty` as `sym::empty`.)
 - rust-lang#141383 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 23, 2025
…InTheVoid

rustdoc JSON: Don't apply `#[repr]` privacy heuristics

Split out from rust-lang#116882.
Context: rust-lang#116882 (comment).
Partially reverts rust-lang#138018.

cc `@obi1kenobi`
r? aDotInTheVoid or rustdoc
bors added a commit that referenced this pull request May 23, 2025
Rollup of 7 pull requests

Successful merges:

 - #136400 (Improve handling of rustdoc lints when used with raw doc fragments.)
 - #140967 (Async drop poll shim for error dropee generates noop body)
 - #141019 (Update std doctests for android)
 - #141109 (discuss deadlocks in the std::io::pipe() example)
 - #141126 (rustdoc JSON: Don't apply `#[repr]` privacy heuristics)
 - #141376 (Rename `kw::Empty` as `sym::empty`.)
 - #141383 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants