Rollup of 7 pull requests #141437
Merged
Rollup of 7 pull requests #141437
+1,024
−348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates some doctests that fail to run on android. We will soon be supporting cross-compiled doctests, and the `arm-android` job fails to run these tests. In summary: - Android re-exports some traits from linux under a different path. - Android doesn't seem to have common unix utilities like `true`, `false`, or `whoami`, so these are disabled.
Add more comments to libc-fs-with-isolation test
bump rustc-build-sysroot
Automatic Rustup
enable clippy::as_conversions to fully rule out as-casts
run tests on mips-unknown-linux-gnu
…ryW-issue GetUserProfileDirectoryW: reference issue regarding implementation details we rely on
Automatic Rustup
test direct usage of io::{stdout,stderr,stdin}
FileDescription: improve read/write docs
implement cpuset_getaffinity for freebsd
1. rustdoc::bare_urls doesn't output invalid suggestions if source_span_for_markdown_range fails to find a span 2. source_span_for_markdown_range tries harder to return a span by applying an additional diagnostic fixes rust-lang#135851
…851, r=GuillaumeGomez Improve handling of rustdoc lints when used with raw doc fragments. 1. `rustdoc::bare_urls` no longer outputs incoherent suggestions if `source_span_for_markdown_range` returns None, instead outputting no suggestion 2. `source_span_for_markdown_range` has one more heuristic, so it will return `None` less often. 3. add ui test to make sure we don't emit nonsense suggestions. fixes rust-lang#135851
…im-for-error-dropee-fix, r=oli-obk Async drop poll shim for error dropee generates noop body Fixes rust-lang#140930. When dropee type for async drop poll shim is `ty::Error(_)`, the generated poll function will be noop body. To avoid ICE in `elaborate_drop`.
…Mark-Simulacrum Update std doctests for android This updates some doctests that fail to run on android. We will soon be supporting cross-compiled doctests, and the `arm-android` job fails to run these tests. In summary: - Android re-exports some traits from linux under a different path. - Android doesn't seem to have common unix utilities like `true`, `false`, or `whoami`, so these are disabled.
…mulacrum discuss deadlocks in the std::io::pipe() example I think it's important to discuss deadlocks in examples of how to use pipes. The current example does include an explicit `drop()`, but it also implicitly relies on the fact that the `Command` object is temporary, so that it drops its copy of `pong_tx`. This sort of thing tends to trip people up when they use pipes for the first time. I might've gone overboard with the comments in this version, but I'm curious what folks think.
…InTheVoid rustdoc JSON: Don't apply `#[repr]` privacy heuristics Split out from rust-lang#116882. Context: rust-lang#116882 (comment). Partially reverts rust-lang#138018. cc `@obi1kenobi` r? aDotInTheVoid or rustdoc
…rochenkov Rename `kw::Empty` as `sym::empty`. Because the empty string is not a keyword. r? `@petrochenkov`
Miri subtree update r? `@ghost`
rustbot
added
A-attributes
|
@bors r+ rollup=never p=5 |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 163cb4e (parent) -> e88e854 (this PR) Test differencesShow 28 test diffsStage 1
Stage 2
Additionally, 22 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e88e85463468ce5d5ce468414eb69e3b15fa8d42 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[repr]privacy heuristics #141126 (rustdoc JSON: Don't apply#[repr]privacy heuristics)kw::Emptyassym::empty. #141376 (Renamekw::Emptyassym::empty.)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup