Skip to content

make teach_help message for cast-before-pass-to-variadic more precise #141443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025

Conversation

RalfJung
Copy link
Member

r? @workingjubilee
based on your comment here

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 23, 2025
@workingjubilee
Copy link
Member

Thank you!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 24, 2025

📌 Commit 180ab16 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2025
@workingjubilee
Copy link
Member

wait, sec

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 24, 2025
Co-authored-by: Jubilee <[email protected]>
@RalfJung
Copy link
Member Author

@bors r=workingjubilee

@bors
Copy link
Collaborator

bors commented May 25, 2025

📌 Commit 4e8b8da has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 25, 2025
bors added a commit that referenced this pull request May 25, 2025
Rollup of 6 pull requests

Successful merges:

 - #141413 (Make #[cfg(version)] respect RUSTC_OVERRIDE_VERSION_STRING)
 - #141443 (make teach_help message for cast-before-pass-to-variadic more precise)
 - #141508 (bootstrap: clippy: set TESTNAME based on given paths)
 - #141512 (Avoid extra path trimming in method not found error)
 - #141530 (Added unstable feature doc comments to unstable book)
 - #141541 (Random nits)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d72bc29 into rust-lang:master May 25, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 25, 2025
rust-timer added a commit that referenced this pull request May 25, 2025
Rollup merge of #141443 - RalfJung:c-variadic-teach-help, r=workingjubilee

make teach_help message for cast-before-pass-to-variadic more precise

r? `@workingjubilee`
based on your comment [here](#44930 (comment))
@RalfJung RalfJung deleted the c-variadic-teach-help branch May 27, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants