Skip to content

Added unstable feature doc comments to unstable book #141530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2025
Merged

Added unstable feature doc comments to unstable book #141530

merged 1 commit into from
May 25, 2025
+38 −6

Conversation

ranger-ross
Copy link
Contributor

@ranger-ross ranger-ross commented May 25, 2025 •
edited by rustbot
Loading

This PR adds doc comments for unstables features in compiler/rustc_feature/src/unstable.rs to the unstable book feature pages.

Fixes #141528

Example features rendered

image

image

r? @jyn514

@rustbot

This comment was marked as resolved.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented May 25, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 25, 2025
Urgau
Urgau reviewed May 25, 2025
View reviewed changes
@Urgau
Copy link
Member

Urgau commented May 25, 2025 •
edited
Loading

r? Urgau @rustbot author

@rustbot rustbot assigned Urgau and unassigned Kobzol May 25, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 25, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@ranger-ross ranger-ross force-pushed the unstable-feature-doc-comments branch from 4169af7 to 3850b1f Compare May 25, 2025 11:00
@ranger-ross
Copy link
Contributor Author

Thanks for the quick review. Addressed your feedback.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 25, 2025
Urgau
Urgau reviewed May 25, 2025
View reviewed changes
@Urgau Urgau added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 25, 2025
@Urgau
Copy link
Member

Urgau commented May 25, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 25, 2025

📌 Commit 3850b1f has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 25, 2025
Merged
bors added a commit that referenced this pull request May 25, 2025
@bors
Auto merge of #141545 - GuillaumeGomez:rollup-myrvuqq, r=GuillaumeGomez
283db70 
Rollup of 6 pull requests

Successful merges:

 - #141413 (Make #[cfg(version)] respect RUSTC_OVERRIDE_VERSION_STRING)
 - #141443 (make teach_help message for cast-before-pass-to-variadic more precise)
 - #141508 (bootstrap: clippy: set TESTNAME based on given paths)
 - #141512 (Avoid extra path trimming in method not found error)
 - #141530 (Added unstable feature doc comments to unstable book)
 - #141541 (Random nits)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5cc2733 into rust-lang:master May 25, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 25, 2025
rust-timer added a commit that referenced this pull request May 25, 2025
@rust-timer
Unrolled build for #141530
e498d66 
Rollup merge of #141530 - ranger-ross:unstable-feature-doc-comments, r=Urgau

Added unstable feature doc comments to unstable book

This PR adds doc comments for unstables features in [compiler/rustc_feature/src/unstable.rs](https://github.com/rust-lang/rust/blob/d3a2440384b54664dddd56e0081ca094c444e869/compiler/rustc_feature/src/unstable.rs#L190-L191) to the unstable book feature pages.

Fixes #141528

Example features rendered

![image](https://github.com/user-attachments/assets/2b65f534-26f8-441f-ba29-65554c9154b7)

![image](https://github.com/user-attachments/assets/6077491b-ddaf-447e-9519-0bc110c7a893)

r? `@jyn514`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau left review comments

Assignees

@Urgau Urgau

Labels
A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

doc-comments on unstable features should end up in the unstable book
5 participants
@ranger-ross @rustbot @Urgau @bors @Kobzol