Skip to content

Clarifications for Hello, Cargo! #27397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2015
Merged

Clarifications for Hello, Cargo! #27397

merged 5 commits into from
Aug 4, 2015

Conversation

Dangthrimble
Copy link
Contributor

Clarifications for those new to Rust and Cargo:

  • It's a good idea to get rid of the original main.exe in project root
  • Slight clarification on the use of main.rs vs lib.rs
  • Clarify that the TOML file needs to be in project root

Just a few minor changes to clarify a few things for someone new to Rust
and Cargo.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Guessing Game states that "Rust only imports a few things into every
program, the ‘prelude’". That isn't strictly true.  That is all it
imports by default and the change clarifies that point.
@alexcrichton
Copy link
Member

r? @steveklabnik

do that part first:
To Cargo-ify our project, we need to do three things: Make a `Cargo.toml`
configuration file, put our source file in the right place, and get rid of the
old `main.exe`. Let's do that part first:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two spaces between 'old' and 'main.exe', and it should say something like 'main or main.exe', to cover all platforms

@Dangthrimble
Copy link
Contributor Author

All requested updated completed apart from issue wrt "This convention ..."

@steveklabnik
Copy link
Member

r=me after the last two bits :)

@Dangthrimble
Copy link
Contributor Author

Changes as requested.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 3, 2015

📌 Commit c54df0e has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thanks so much!

@bors
Copy link
Collaborator

bors commented Aug 4, 2015

⌛ Testing commit c54df0e with merge 934e078...

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 4, 2015
Clarifications for those new to Rust and Cargo:
* It's a good idea to get rid of the original `main.exe` in project root
* Slight clarification on the use of `main.rs` vs `lib.rs`
* Clarify that the TOML file needs to be in project root
@bors
Copy link
Collaborator

bors commented Aug 4, 2015

⛄ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request Aug 4, 2015
@bors bors merged commit c54df0e into rust-lang:master Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants