Fix "Ignoring variants" in "Patterns" chapter #27460
Conversation
- Fix rust-lang#26968 by noting the difference between ".." and "_" more explicitly - Change one of the examples to show the match-all behaviour of ".." - Merge "Ignoring variants" and "Ignoring bindings" sections into the latter
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
This is great! Thanks so much |
|
@bors: r+ rollup |
|
📌 Commit 91972ba has been approved by |
|
⌛ Testing commit 91972ba with merge f1a98a1... |
|
I'm glad to help. |
|
@JanLikar It looks like you pushed another change to this branch after it was accepted -- did you intend to do this? |
|
Ooh, I see. I am working on further improvements to the docs and no, this was not intended. I was sure that I can push the branch without adding a commit to the pull request. BTW, how can I do that? EDIT: Fixed. Now it's ready to be merged. |
|
@bors: r+ rollup |
|
📌 Commit 91972ba has been approved by |
- Fix rust-lang#26968 by noting the difference between ".." and "_" more explicitly - Change one of the examples to show the match-all behaviour of ".." - Merge "Ignoring variants" and "Ignoring bindings" sections into the latter r? @steveklabnik
r? @steveklabnik