-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rollup of 7 pull requests #28423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rollup of 7 pull requests #28423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Sep 15, 2015
- Successful merges: Adding detailed error text for E0118 #28263, Small syntax and formatting changes #28276, Add a remark about the implicit implementation of Send and make a test for it #28314, Fix typo for @bors cheetsheet #28401, Add test for #23036 #28417, Fix option link and anchor links. #28420, Add anchors links for linked code snippets. #28422
- Failed merges:
…nikomatsakis Contributing to the Rust error explanations. Should I also add a better error for it by default?
…urnstushi, r=steveklabnik This was pointed out by @filsmick and @swatteau in rust-lang#28412.
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ p=1 |
📌 Commit d895106 has been approved by |
⌛ Testing commit d895106 with merge 7d46b64... |
💔 Test failed - auto-mac-64-opt |
Can someone tell bors to retry? |
Not a spurious failure. Looks like #28314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.