Rustfmt-ing libarena. #29020
Rustfmt-ing libarena. #29020
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| } | ||
|
|
||
| trait AllTypes { fn dummy(&self) { } } | ||
| trait AllTypes { fn dummy(&self) { | ||
| } } |
There was a problem hiding this comment.
this is not an improvement. I'd report a bug against rustfmt
There was a problem hiding this comment.
|
@nrc Manual fixups done as well as reported rustfmt issues. |
| @@ -105,7 +105,7 @@ pub struct Arena<'longer_than_self> { | |||
| head: RefCell<Chunk>, | |||
| copy_head: RefCell<Chunk>, | |||
| chunks: RefCell<Vec<Chunk>>, | |||
| _marker: marker::PhantomData<*mut &'longer_than_self()>, | |||
| _marker: marker::PhantomData<*mut &'longer_than_self ()>, | |||
There was a problem hiding this comment.
hmm, this seems to be erroneous too on second glance
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh actually, it's not sorry, that's a lifetime
|
@nrc Comment fixed |
|
@bors: r+ rollup |
|
📌 Commit e7be2c3 has been approved by |
…, r=nrc Hi Rustaceans! This is the result of running latest rustfmt on libarena! //cc @nrc
Hi Rustaceans! This is the result of running latest rustfmt on libarena! //cc @nrc
|
⌛ Testing commit e7be2c3 with merge 24228fe... |
Hi Rustaceans!
This is the result of running latest rustfmt on libarena!
//cc @nrc