Rollup of 7 pull requests #29090
Closed
Rollup of 7 pull requests #29090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Oct 16, 2015
Manishearth
commented
- Successful merges: Rustfmt-ing libarena. #29020, Rustfmt-ing librustc_driver. #29033, Remove unused files from libcoretest #29079, Remove outdated Changing directory. #29080, Fix minor error in Arc docs #29081, Make NonZero::new const function #29085, Update lint plugin example in book to work with recent master #29086
- Failed merges:
The text says it's a vector of floats, but the code actually uses a vector of integers. The type of the Vec doesn't really matter, so I just cut it from the text.
The implementation for `into_inner` was a bit more complex than I had hoped for---is there any simpler, less unsafe way of getting around the fact that one can't move out of a `Drop` struct? See rust-lang#28968 and rust-lang/rfcs#1269 .
…, r=nrc Hi Rustaceans! This is the result of running latest rustfmt on libarena! //cc @nrc
…_driver, r=nrc Hi Rustaceans! This is the result of running latest rustfmt on librustc_driver! This is a longer one! //cc @nrc
…st, r=alexcrichton While working on rust-lang#28711 I found out that * src/libcoretest/clone.rs * src/libcoretest/fmt/float.rs * src/libcoretest/intrinsics.rs are not used. I am not sure if removing them is the right way to go. If it makes sense to keep (and fix and enable) them, I would be happy to update the PR.
…alexcrichton Fixes issue rust-lang#29077. There **are** API changing guidelines in the RFCs, so it might be prudent to put those there. But I'm leaving that up to another person. This PR just removes bad documentation.
…richton The text says it's a vector of floats, but the code actually uses a vector of integers. The type of the Vec doesn't really matter, so I just cut it from the text.
…le, r=alexcrichton
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 force |
|
📌 Commit 9726149 has been approved by |
|
⌛ Testing commit 9726149 with merge 501d588... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
Looks like these PRs have been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.