-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rustfmt-ing librustc_driver. #29033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustfmt-ing librustc_driver. #29033
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
r? @nrc |
if log_enabled!(::log::INFO) { | ||
println!("Post-trans"); | ||
tcx.print_debug_stats(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need to fix this for large blocks...
Thanks for the PR, there's a few things to fix up. I also wonder what to do about the huge whitespace we've created for the big closures. We could wait until we fix rustfmt, we could land as is, or we could manually fixup and revisit once rustfmt is improved. Do you have a preference? I think I'd prefer the second option. |
Hey @nrc Manual fixups made and rustfmt issues reported, we should be good now. |
Thanks for the changes! @bors: r+ (no rollup because it's big and there was a compile bug in an earlier commit) |
📌 Commit 59a3518 has been approved by |
⌛ Testing commit 59a3518 with merge 9bc674b... |
💔 Test failed - auto-mac-64-nopt-t |
You'll need to add |
@nrc Oh thanks added! |
@bors: r+ |
📌 Commit 605fef2 has been approved by |
⌛ Testing commit 605fef2 with merge 6f18bc4... |
💔 Test failed - auto-mac-64-opt |
@bors: retry On Thu, Oct 15, 2015 at 5:48 PM, bors [email protected] wrote:
|
…_driver, r=nrc Hi Rustaceans! This is the result of running latest rustfmt on librustc_driver! This is a longer one! //cc @nrc
⌛ Testing commit 605fef2 with merge c4fbea8... |
💔 Test failed - auto-mac-64-opt |
Looks like the error may not be spurious? Perhaps something was accidentally changed here? |
tidy error, looks like we broke a line in driver.rs |
☔ The latest upstream changes (presumably #29171) made this pull request unmergeable. Please resolve the merge conflicts. |
605fef2
to
9393587
Compare
☔ The latest upstream changes (presumably #29241) made this pull request unmergeable. Please resolve the merge conflicts. |
Closing this in favor of #29650 |
Hi Rustaceans!
This is the result of running latest rustfmt on librustc_driver!
This is a longer one!
//cc @nrc