Rollup of 9 pull requests #29069
Closed
Rollup of 9 pull requests #29069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the first "A Rust library" code sample produced
the following compilation warning:
```
test.rs:7:22: 7:36 warning: unnecessary parentheses around `for` head
expression, #[warn(unused_parens)] on by default
test.rs:7 for _ in (0..5_000_000) {
```
This commit just removes the parens around the range 0..5_000_000.
Shoud have been part of commit 0b13ee0
r? @nrc I was wondering, what is the standard for pattern matching in presence of guards? I liked more the original alignment of `distributions/gamma.rs` line 91 than the new one.
Shoud have been part of commit 0b13ee0
…ning, r=alexcrichton
Before this commit, the first "A Rust library" code sample produced
the following compilation warning:
```
test.rs:7:22: 7:36 warning: unnecessary parentheses around `for` head
expression, #[warn(unused_parens)] on by default
test.rs:7 for _ in (0..5_000_000) {
```
This commit just removes the parens around the range 0..5_000_000 thereby removing the compilation warning.
…bnik Regarding [rust-lang#29063 _[Docs] Terminology inconsistency between 'iterator adapters' and 'iterator adaptors'_](rust-lang#29063) : This PR replaces 'iterator adapters' appearances (in TRPL book) to 'iterator adaptors', thus embracing the terminology used along the API docs and achieving consistency between both sources.
|
@bors: r+ p=1 |
|
📌 Commit 46d8a76 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 46d8a76 with merge eac6986... |
|
💔 Test failed - auto-linux-64-nopt-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaulttrait in the prelude docs #29047, rustfmt librand/distributions #29054, reference: 'struct' is more common that 'structure' #29058, book: fix typo #29059, book: be consistent with preceding example #29060, Resolve unused_parens compilation warning #29062, Replace 'iterator adapters' to 'iterator adaptors' in TRPL book #29066