Remove unused files from libcoretest

[fhahn]

While working on #28711 I found out that

• src/libcoretest/clone.rs
• src/libcoretest/fmt/float.rs
• src/libcoretest/intrinsics.rs

are not used. I am not sure if removing them is the right way to go. If it makes sense to keep (and fix and enable) them, I would be happy to update the PR.

[rust-highfive]

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

[brson]

It looks to me like they should be added to coretest since these tests don't exist anywhere else. Can you add them back to the crate?

[fhahn]

Yeah that makes sense. I've updated the PR. I only changed int to i32 and had to remove a test which used clone() on functions (I am not sure, is something like this still supported?)

[alexcrichton]

@bors: r+ 6aa5237

Yay!

[bors]

⌛ Testing commit 6aa5237 with merge 3687c5f...

[bors]

⛄ The build was interrupted to prioritize another pull request.

[bors]

⌛ Testing commit 6aa5237 with merge a668a03...

[bors]

💔 Test failed - auto-mac-32-opt

[fhahn]

It seems like to rounding behavior has changed: format!("{:.1}" , 9.85f64) prints 9.8 instead of the expected 9.9. Is this a regression? According to the documentation , round() should round half-way cases away from zero. format!("{:.1}" , 9.851f64) generates 9.9 as expected.

[alexcrichton]

I believe that's probably because 9.85 isn't representable as a float, for example:

$ cat foo.rs
fn main() {
    let a = 9.85;
    println!("{}", a);
}
$ rustc -g foo.rs
$ lldb ./foo
(lldb) target create "./foo"
bCurrent executable set to './foo' (x86_64).
(lldb) b foo.rs:3
Breakpoint 1: where = foo`foo::main + 107 at foo.rs:3, address = 0x000000010000156b
(lldb) r
Process 98510 launched: './foo' (x86_64)
Process 98510 stopped
* thread #1: tid = 0xdf51c, 0x000000010000156b foo`foo::main + 107 at foo.rs:3, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
    frame #0: 0x000000010000156b foo`foo::main + 107 at foo.rs:3
   1    fn main() {
   2        let a = 9.85;
-> 3        println!("{}", a);
   4    }
(lldb) print a
(double) $0 = 9.8499999999999996
(lldb) 

[fhahn]

Ah I see. I have updated the test.

[alexcrichton]

@bors: r+ 510360d

[bors]

⌛ Testing commit 510360d with merge 4ed46e7...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt