Fixed #17823

[KalitaAlexey]

No description provided.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[KalitaAlexey]

I have a few questions. I fixed but and I formatted error_reporting.rs with rustfmt. Is it ok? I'd like to write test where error does not contain pattern. I see that currently compiletest has no such feature.

[alexcrichton]

Could the rustfmt changes be separated out? Unfortunately they're large enough that github doesn't display the diff :(

[KalitaAlexey]

@alexcrichton Yes. I can. Should I close this pull request?

[alexcrichton]

Nah feel free to just force-push this branch to one of the changes and open another for the other change

[KalitaAlexey]

@alexcrichton I don't understand you. I am new to git. May we chat somewhere?

[alexcrichton]

Ah yeah what's here is fine, you may want to also try an interactive git rebase to remove the first two commits so the PR only contains the last one.

r? @nrc

[nrc]

This should be a method on TyS rather than a function here - is_primitive maybe

[KalitaAlexey]

@alexcrichton I already pushed commits. How to remove it?

[alexcrichton]

The git rebase -i command should do the trick (followed by git push -f), and I found some good explanation of that online.

[KalitaAlexey]

There is "all before you share your work with others." on that page. I already pushed changes to repository.

[alexcrichton]

That's moreso a message for when you've pushed to the branch of a repo, these haven't been published yet as they're just a PR.

[KalitaAlexey]

But my repository already has those commits. What should I do to erase them? Should I do another fork?

[KalitaAlexey]

I know how to do that. I must close PR and open new with correct changes. Is it right?

[KalitaAlexey]

#30953 New PR.

[nrc]

@KalitaAlexey you don't need to close the PR, a branch on your repo doesn't count as 'public', only a branch on a repo other people use. So you can force push to your old branch, keeping the PR open.