Skip to content

Fixed #17823. Changed tests to work with fix. #30953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2016
Merged

Fixed #17823. Changed tests to work with fix. #30953

merged 1 commit into from
Jan 18, 2016

Conversation

KalitaAlexey
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@KalitaAlexey KalitaAlexey mentioned this pull request Jan 16, 2016
@alexcrichton
Copy link
Member

r? @nrc (carrying over from #30937)

@rust-highfive rust-highfive assigned nrc and unassigned alexcrichton Jan 16, 2016
@nrc
Copy link
Member

nrc commented Jan 17, 2016

Could you amend the commit to give it a more descriptive message please?

@nrc
Copy link
Member

nrc commented Jan 17, 2016

r+ with a better commit message

@KalitaAlexey
Copy link
Contributor Author

Which message do you want? I just think that current message is good.

@KalitaAlexey
Copy link
Contributor Author

r+ simplify E0308 message for primitive types

@nrc
Copy link
Member

nrc commented Jan 18, 2016

"Changed tests to work with fix." doesn't really describe the commit. I like "simplify E0308 message for primitive types" much better.

git commit --amend -m "simplify E0308 message for primitive types"
git push origin <branch name> -f

should be all you need to do to update it.

@KalitaAlexey
Copy link
Contributor Author

I made it @nrc.

@nrc
Copy link
Member

nrc commented Jan 18, 2016

Thanks!

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 18, 2016

📌 Commit 8a41eb5 has been approved by nrc

bors added a commit that referenced this pull request Jan 18, 2016
@bors
Copy link
Collaborator

bors commented Jan 18, 2016

⌛ Testing commit 8a41eb5 with merge 9d21aca...

@bors bors merged commit 8a41eb5 into rust-lang:master Jan 18, 2016
@KalitaAlexey KalitaAlexey deleted the 17823-get-rid-of-duplicate-error branch January 18, 2016 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants