Removed unused E0406 and unused functions #34342
Conversation
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
| this.with_type_parameter_rib(NoTypeParameters, |this| { | ||
| visit::walk_trait_item(this, trait_item) | ||
| }); | ||
| types.push(format!("{}", trait_item.ident)); |
There was a problem hiding this comment.
You don't need/want to convert them to strings, comparing Names is O(1).
|
This breaks associated types that come from a different trait which I don't know what |
It does recurse, I added the |
|
@GuillaumeGomez Oh hah, I missed that because of singular/plural. |
|
I can take up the task of updating |
|
No, you can do it as soon as you want. The PR will just remove unused mechanisms. |
| this.with_type_parameter_rib(NoTypeParameters, |this| { | ||
| visit::walk_trait_item(this, trait_item) | ||
| }); | ||
| } |
There was a problem hiding this comment.
I think this change (moving the match arms) is unnecessary.
GuillaumeGomez
changed the title
GuillaumeGomez
force-pushed
the
E0406
branch
2 times, most recently
from
7f0cac0 to
b54341e
Compare
|
@bors r+ |
|
📌 Commit 8637b4b has been approved by |
Modified E0220 to show error messages for more general cases This PR extends `E0220`'s description to explain more cases. Refer to [#34342](#34342) for more. r? @GuillaumeGomez
Fixes #34301.
It removes the unused E0406 and also unused functions.
cc @eddyb