-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Removed unused E0406 and unused functions #34342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
this.with_type_parameter_rib(NoTypeParameters, |this| { | ||
visit::walk_trait_item(this, trait_item) | ||
}); | ||
types.push(format!("{}", trait_item.ident)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need/want to convert them to strings, comparing Name
s is O(1)
.
This breaks associated types that come from a different trait which I don't know what |
It does recurse, I added the |
@GuillaumeGomez Oh hah, I missed that because of singular/plural. |
I can take up the task of updating |
No, you can do it as soon as you want. The PR will just remove unused mechanisms. |
this.with_type_parameter_rib(NoTypeParameters, |this| { | ||
visit::walk_trait_item(this, trait_item) | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change (moving the match arms) is unnecessary.
7f0cac0
to
b54341e
Compare
@bors r+ |
📌 Commit 8637b4b has been approved by |
Modified E0220 to show error messages for more general cases This PR extends `E0220`'s description to explain more cases. Refer to [#34342](#34342) for more. r? @GuillaumeGomez
Fixes #34301.
It removes the unused E0406 and also unused functions.
cc @eddyb