Modified E0220 to show error messages for more general cases #34364
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
|
||
| trait Trait { | ||
| type Bar; | ||
| type Baz; // Baz has been defined before being used |
There was a problem hiding this comment.
Hum... This sentence implies that a type must be defined before being used, which is wrong:
trait Foo {
fn foo(&self, Self::Bar);
type Bar;
}What about:
trait Trait {
type Bar;
type Baz; // we declare the `Baz` associated type in our trait `Trait`.
// and now we can use it here:
fn return_bool(&self, &Self::Bar, &Self::Baz) -> bool;
?
There was a problem hiding this comment.
yes, that one seems better. Will change it.
|
I noticed that the terms 'declared' and 'defined' are being used interchangeably here. Should I change the error message to be more consistent and use one word throughout, or is it ok as it is? |
|
It didn't hit me so I'd say you can keep it this way. |
|
Fixed the changes. |
|
|
||
| // or: | ||
|
|
||
| trait Trait { |
There was a problem hiding this comment.
You cannot put the same trait name in this same block, otherwise the test will fail. Either you change the trait's name or you create a new code block.
|
Once the last nit fixed, please squash your commits. |
|
Fixed trait names and squashed commits; all tests should pass now. |
| @@ -2787,23 +2787,43 @@ You used an associated type which isn't defined in the trait. | |||
| Erroneous code example: | |||
|
|
|||
| ```compile_fail | |||
| trait Trait { | |||
| trait T1 { | |||
| type Bar; | |||
| } | |||
|
|
|||
| type Foo = Trait<F=i32>; // error: associated type `F` not found for | |||
|
Sorry for that, I have fixed them now. Please take a look. |
| type Foo = Trait<F=i32>; // error: associated type `F` not found for | ||
| // `Trait` | ||
| type Foo = T1<F=i32>; // error: associated type `F` not found for | ||
| // `T1` |
There was a problem hiding this comment.
This line isn't aligned with the previous one.
|
One last nit! 😛 |
|
Fixed. |
|
Thanks for your patience! @bors: r+ rollup |
|
📌 Commit 09ffe47 has been approved by |
Modified E0220 to show error messages for more general cases This PR extends `E0220`'s description to explain more cases. Refer to [#34342](#34342) for more. r? @GuillaumeGomez
This PR extends
E0220's description to explain more cases.Refer to #34342 for more.
r? @GuillaumeGomez