-
Notifications
You must be signed in to change notification settings - Fork 13.3k
auto: Rustpkg #4799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto: Rustpkg #4799
Conversation
It looks like tests failed but these tests are completely unrelated to rustpkg (I haven't touched anything outside of rustpkg except semver). Any idea what's going on here @graydon? |
No, but curiously it also reliably locks up when I test locally. Hopefully I'll have more time to diagnose next week. |
I have a feeling this needs to be rebased and reviewed again, because it seems it got stuck between some bad commits. |
I've been doing so daily in my own repo but am behind today. It'd be substantially easier if the code synthesis part used quotes rather than the manual ast construction. I'll try to update it to work that way. Sorry this is taking so long. Lots of churn. If you want to rebase ahead of me, by all means. |
I'm trying to rebase this. I'll see how far I get. |
I did get to this today; have a version building with most of the ast code replaced with quotes. Don't bother. I'll post tomorrow. |
(sorry for the mixed messages) |
ok |
Removed hacky dependency on Round trait and generic infinity functions Removed generic-runtime-failure-depending-on-type behavior
Removed Round impl for integers
Moved `is_*` predicates into standalone functions
Moved them into own module and made them not depend on an Round trait impl for integers and generic math functions that can fail on integers any more.
…o workcache or dependency resolution yet)
…c_dir in librustpkg
Taking over where #4610 left off. Much rebasing and tidying.
This doesn't fold over crates ( |
Taking over where #4610 left off. Much rebasing and tidying.