Skip to content

Remove rtdebug_! and make rtdebug! work properly. #8419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2013
Merged

Remove rtdebug_! and make rtdebug! work properly. #8419

merged 1 commit into from
Aug 13, 2013

Conversation

emberian
Copy link
Member

@emberian emberian commented Aug 9, 2013

It now actually does logging, and is compiled out when --cfg rtdebug is not
given to the libstd build, which it isn't by default. This makes the rt
benchmarks 18-50% faster.

It now actually does logging, and is compiled out when `--cfg rtdebug` is not
given to the libstd build, which it isn't by default. This makes the rt
benchmarks 18-50% faster.
bors added a commit that referenced this pull request Aug 12, 2013
It now actually does logging, and is compiled out when `--cfg rtdebug` is not
given to the libstd build, which it isn't by default. This makes the rt
benchmarks 18-50% faster.
@bors bors closed this Aug 13, 2013
@bors bors merged commit 4be086b into rust-lang:master Aug 13, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 24, 2022
Fix `await_holding_lock` not linting `parking_lot` Mutex/RwLock

This adds tests for `RwLock` and `parking_lot::{Mutex, RwLock}`, which were added before in rust-lang/rust-clippy@2dc8c08, but never tested in UI tests. I noticed this while reading [fasterthanli.me](https://fasterthanli.me/articles/a-rust-match-made-in-hell) latest blog post, complaining that Clippy doesn't catch this for `parking_lot`. (Too many people read his blog, he's too powerful)

Some more things:
- Adds a test for rust-lang#6446
- Improves the lint message

changelog: [`await_holding_lock`]: Now also lints for `parking_lot::{Mutex, RwLock}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants