Skip to content

Add cygwin support #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 24, 2025
Merged

Add cygwin support #568

merged 14 commits into from
May 24, 2025

Conversation

Berrysoft
Copy link
Contributor

This PR makes it compile on cygwin.

Thomasdezeeuw
Thomasdezeeuw reviewed Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add something to the CI to ensure it keeps working?

@Berrysoft
Copy link
Contributor Author

Can we add something to the CI to ensure it keeps working?

It actually doesn't work all the time, because of bugs of cygwin. To be specific, the test unix hangs. Is it OK to ignore this test on cygwin and add a job to CI?

@Berrysoft
Copy link
Contributor Author

The maintainer of cygwin told me a workaround for the test unix. I have commited it.

Thomasdezeeuw
Thomasdezeeuw reviewed Apr 12, 2025
View reviewed changes
@Berrysoft Berrysoft requested a review from Thomasdezeeuw April 14, 2025 14:08
@Berrysoft Berrysoft mentioned this pull request Apr 21, 2025
Closed
4 tasks
@Berrysoft
Copy link
Contributor Author

@Thomasdezeeuw ping?

@Berrysoft
Copy link
Contributor Author

Could you review this PR again? @Thomasdezeeuw

Darksonn
Darksonn reviewed May 8, 2025
View reviewed changes
@Berrysoft Berrysoft requested a review from Darksonn May 11, 2025 14:19
@Berrysoft Berrysoft mentioned this pull request May 13, 2025
Merged
8 tasks
@Berrysoft
Copy link
Contributor Author

@Thomasdezeeuw @Darksonn Would you review again? This PR is the last blocker to build cargo on cygwin.

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw @Darksonn Would you review again? This PR is the last blocker to build cargo on cygwin.

I'm sorry to be blocking you, I've just been really busy lately and have very little spare time to review stuff (also see any pr on this repo). I'll try to give it a proper review again, but I can't promise anything.

fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
@fmease
Rollup merge of rust-lang#140154 - Berrysoft:cygwin-host, r=jieyouxu
c052645 
Cygwin support in rustc

This PR builds host rustc targeting cygwin.

- [x] rust-lang/stacker#122
- [x] nagisa/rust_libloading#173
- [x] Detegr/rust-ctrlc#131
- [x] rust-random/getrandom#654
- [x] msys2/MSYS2-packages#5350
- [x] rust-lang#140886
- [x] rust-lang#140921
- [x] rust-lang#140973

Currently supported:
* rustc
* rustdoc
* rustfmt
* clippy

Blocking:
* cargo: blocked by rust-lang/socket2#568
* rust-analyzer: needs `cargo update`, fixed upstream

```
$ rustc --version --verbose
rustc 1.88.0-dev
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-pc-cygwin
release: 1.88.0-dev
LLVM version: 20.1.4
```
fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
@fmease
Rollup merge of rust-lang#140154 - Berrysoft:cygwin-host, r=jieyouxu
47047c7 
Cygwin support in rustc

This PR builds host rustc targeting cygwin.

- [x] rust-lang/stacker#122
- [x] nagisa/rust_libloading#173
- [x] Detegr/rust-ctrlc#131
- [x] rust-random/getrandom#654
- [x] msys2/MSYS2-packages#5350
- [x] rust-lang#140886
- [x] rust-lang#140921
- [x] rust-lang#140973

Currently supported:
* rustc
* rustdoc
* rustfmt
* clippy

Blocking:
* cargo: blocked by rust-lang/socket2#568
* rust-analyzer: needs `cargo update`, fixed upstream

```
$ rustc --version --verbose
rustc 1.88.0-dev
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-pc-cygwin
release: 1.88.0-dev
LLVM version: 20.1.4
```
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@bors
Auto merge of rust-lang#140154 - Berrysoft:cygwin-host, r=jieyouxu
27c4e28 
Cygwin support in rustc

This PR builds host rustc targeting cygwin.

- [x] rust-lang/stacker#122
- [x] nagisa/rust_libloading#173
- [x] Detegr/rust-ctrlc#131
- [x] rust-random/getrandom#654
- [x] msys2/MSYS2-packages#5350
- [x] rust-lang#140886
- [x] rust-lang#140921
- [x] rust-lang#140973

Currently supported:
* rustc
* rustdoc
* rustfmt
* clippy

Blocking:
* cargo: blocked by rust-lang/socket2#568
* rust-analyzer: needs `cargo update`, fixed upstream

```
$ rustc --version --verbose
rustc 1.88.0-dev
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-pc-cygwin
release: 1.88.0-dev
LLVM version: 20.1.4
```
fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
@fmease
Rollup merge of rust-lang#140154 - Berrysoft:cygwin-host, r=jieyouxu
45369d4 
Cygwin support in rustc

This PR builds host rustc targeting cygwin.

- [x] rust-lang/stacker#122
- [x] nagisa/rust_libloading#173
- [x] Detegr/rust-ctrlc#131
- [x] rust-random/getrandom#654
- [x] msys2/MSYS2-packages#5350
- [x] rust-lang#140886
- [x] rust-lang#140921
- [x] rust-lang#140973

Currently supported:
* rustc
* rustdoc
* rustfmt
* clippy

Blocking:
* cargo: blocked by rust-lang/socket2#568
* rust-analyzer: needs `cargo update`, fixed upstream

```
$ rustc --version --verbose
rustc 1.88.0-dev
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-pc-cygwin
release: 1.88.0-dev
LLVM version: 20.1.4
```
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@bors
Auto merge of rust-lang#140154 - Berrysoft:cygwin-host, r=jieyouxu
e42bbfe 
Cygwin support in rustc

This PR builds host rustc targeting cygwin.

- [x] rust-lang/stacker#122
- [x] nagisa/rust_libloading#173
- [x] Detegr/rust-ctrlc#131
- [x] rust-random/getrandom#654
- [x] msys2/MSYS2-packages#5350
- [x] rust-lang#140886
- [x] rust-lang#140921
- [x] rust-lang#140973

Currently supported:
* rustc
* rustdoc
* rustfmt
* clippy

Blocking:
* cargo: blocked by rust-lang/socket2#568
* rust-analyzer: needs `cargo update`, fixed upstream

```
$ rustc --version --verbose
rustc 1.88.0-dev
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-pc-cygwin
release: 1.88.0-dev
LLVM version: 20.1.4
```
@Berrysoft
Copy link
Contributor Author

@Thomasdezeeuw

I'm sorry to be blocking you, I've just been really busy lately and have very little spare time to review stuff...

Well, it's OK. Anyone has their busy time:)

It seems that you're the only active maintainer of this repo...? It's a little surprising because, I thought that the rust crates team should maintain such fundamental crate more actively:)

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request May 19, 2025
@bors
Auto merge of #140154 - Berrysoft:cygwin-host, r=jieyouxu
ef2d6ad 
Cygwin support in rustc

This PR builds host rustc targeting cygwin.

- [x] rust-lang/stacker#122
- [x] nagisa/rust_libloading#173
- [x] Detegr/rust-ctrlc#131
- [x] rust-random/getrandom#654
- [x] msys2/MSYS2-packages#5350
- [x] rust-lang/rust#140886
- [x] rust-lang/rust#140921
- [x] rust-lang/rust#140973

Currently supported:
* rustc
* rustdoc
* rustfmt
* clippy

Blocking:
* cargo: blocked by rust-lang/socket2#568
* rust-analyzer: needs `cargo update`, fixed upstream

```
$ rustc --version --verbose
rustc 1.88.0-dev
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-pc-cygwin
release: 1.88.0-dev
LLVM version: 20.1.4
```
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 19, 2025
@bors
Auto merge of #140154 - Berrysoft:cygwin-host, r=jieyouxu
2b1650e 
Cygwin support in rustc

This PR builds host rustc targeting cygwin.

- [x] rust-lang/stacker#122
- [x] nagisa/rust_libloading#173
- [x] Detegr/rust-ctrlc#131
- [x] rust-random/getrandom#654
- [x] msys2/MSYS2-packages#5350
- [x] rust-lang/rust#140886
- [x] rust-lang/rust#140921
- [x] rust-lang/rust#140973

Currently supported:
* rustc
* rustdoc
* rustfmt
* clippy

Blocking:
* cargo: blocked by rust-lang/socket2#568
* rust-analyzer: needs `cargo update`, fixed upstream

```
$ rustc --version --verbose
rustc 1.88.0-dev
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-pc-cygwin
release: 1.88.0-dev
LLVM version: 20.1.4
```
Darksonn
Darksonn reviewed May 19, 2025
View reviewed changes
@Berrysoft Berrysoft requested a review from Darksonn May 21, 2025 12:16
Darksonn
Darksonn reviewed May 21, 2025
View reviewed changes
@Berrysoft Berrysoft requested a review from Darksonn May 22, 2025 06:34
Darksonn
Darksonn reviewed May 22, 2025
View reviewed changes
@Berrysoft @Darksonn
Apply suggestions from code review
5d7bd84 
Simplify `cfg`s

Co-authored-by: Alice Ryhl <[email protected]>
@Berrysoft Berrysoft requested a review from Darksonn May 22, 2025 23:18
Thomasdezeeuw
Thomasdezeeuw approved these changes May 24, 2025
View reviewed changes
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Berrysoft apologies again for this taking so long. I have one small nit, which moving the Socket::set_no_peercred function. To not block it any further I pushed it:
926917b, and once the CI is green I'll merge this.

@Berrysoft
Copy link
Contributor Author

@Thomasdezeeuw CI's failing. You see, that's why I move the function out.

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw CI's failing. You see, that's why I move the function out.

I'll fix it. The function still has to be in the sys module.

@Berrysoft
Copy link
Contributor Author

Thanks!

@Thomasdezeeuw Thomasdezeeuw merged commit 1fe6c54 into rust-lang:master May 24, 2025
43 of 44 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @Berrysoft!

@Berrysoft Berrysoft deleted the dev/cygwin branch May 24, 2025 08:55
@Berrysoft
Copy link
Contributor Author

Thank you @Thomasdezeeuw . May I ask about the release plan? When is the next release?

Berrysoft added a commit to Berrysoft/socket2 that referenced this pull request May 24, 2025
@Berrysoft @Darksonn @Thomasdezeeuw
Add cygwin support (rust-lang#568)
c82d6a6 
Co-authored-by: Alice Ryhl <[email protected]>
Co-authored-by: Thomas de Zeeuw <[email protected]>
@Berrysoft Berrysoft mentioned this pull request May 24, 2025
Merged
@Thomasdezeeuw
Copy link
Collaborator

Thank you @Thomasdezeeuw . May I ask about the release plan? When is the next release?

Not sure yet. I want drop libc from the public API, like we just did with window-sys. Hopefully I have time for that this weekend

Thomasdezeeuw added a commit that referenced this pull request May 24, 2025
@Berrysoft @Darksonn @Thomasdezeeuw
Add cygwin support (#568) (#578)
d71f29b 
Co-authored-by: Alice Ryhl <[email protected]>
Co-authored-by: Thomas de Zeeuw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyd2019 jeremyd2019 jeremyd2019 left review comments

@Darksonn Darksonn Darksonn approved these changes

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Berrysoft @Thomasdezeeuw @Darksonn @jeremyd2019