-
Notifications
You must be signed in to change notification settings - Fork 289
Add vld1q_f32 #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vld1q_f32 #892
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
3b7831a
to
c2fc05f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning on adding all the other vld*
intrinsics as well?
My plan was to just do |
e844e6c
to
90dc97e
Compare
ef4d2a2
to
e0c0990
Compare
The alignment requirements should match the pointer type. See llvm commit 8beaba13b8a61697008854b82ed3b45377af9d9d
LGTM. Do you want to try implementing the other vector load intrinsics as well or do you just want me to merge this? |
Let's merge this and I'll look at the other intrinsics next. |
No description provided.