Skip to content

Add vld1q_f32 #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2020
Merged

Add vld1q_f32 #892

merged 1 commit into from
Sep 7, 2020

Conversation

jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Sep 5, 2020

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jrmuizel jrmuizel force-pushed the vld1q_f32 branch 15 times, most recently from 3b7831a to c2fc05f Compare September 5, 2020 21:20
Amanieu
Amanieu reviewed Sep 6, 2020
View reviewed changes
Copy link
Member

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on adding all the other vld* intrinsics as well?

@jrmuizel
Copy link
Contributor Author

jrmuizel commented Sep 7, 2020

Are you planning on adding all the other vld* intrinsics as well?

My plan was to just do vld1q_f32 and vld1q_dup_f32 as those are the ones I need. But once I've got the hang of things I might add the others too.

@jrmuizel jrmuizel force-pushed the vld1q_f32 branch 4 times, most recently from e844e6c to 90dc97e Compare September 7, 2020 19:04
@jrmuizel jrmuizel force-pushed the vld1q_f32 branch 4 times, most recently from ef4d2a2 to e0c0990 Compare September 7, 2020 19:42
@jrmuizel jrmuizel marked this pull request as draft September 7, 2020 19:50
@jrmuizel
Add vld1q_f32 intrinsic
c3d8684 
The alignment requirements should match the pointer type. See
llvm commit 8beaba13b8a61697008854b82ed3b45377af9d9d
@Amanieu
Copy link
Member

Amanieu commented Sep 7, 2020

LGTM. Do you want to try implementing the other vector load intrinsics as well or do you just want me to merge this?

@jrmuizel jrmuizel changed the title WIP add vld1q_f32 Add vld1q_f32 Sep 7, 2020
@jrmuizel jrmuizel marked this pull request as ready for review September 7, 2020 20:45
@jrmuizel
Copy link
Contributor Author

jrmuizel commented Sep 7, 2020

Let's merge this and I'll look at the other intrinsics next.

@Amanieu Amanieu merged commit adc5814 into rust-lang:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees

@Amanieu Amanieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrmuizel @rust-highfive @Amanieu