Skip to content

Replace Modal's default true prop: dismissable #503

Closed
@interactivellama

Description

@interactivellama

JSX props should not be true by default.

My suggestion is to deprecate dismissable and remove it from the propTypes and use the following.

/**
 * If true, Modals cannot be dismissed by clicking on the close icon or pressing esc key.
 */
disableClose: React.PropTypes.bool,
``

This should first be warned with a console error with dismissable is used.

This should not be a breaking change.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions