Replace dismissible with disableClose in Modal

[aswinshenoy]

Fixes #503

Additional description

Replaced instances of the prop-type dismissible with disableClose

---

CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

• First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
• npm run lint:fix has been run and linting passes.
• Review the appropriate Storybook stories. Open http://localhost:9001/.
• Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
• Tests have been added for new props to prevent regressions in the future. See readme.
• The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
• Review tests are passing in the browser. Open http://localhost:8001/.
• Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

• TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
• Tests have been added for new props to prevent regressions in the future. See readme.
• Review the appropriate Storybook stories. Open http://localhost:9001/.
• The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
• Review tests are passing in the browser. Open http://localhost:8001/.
• Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

• Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
• Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
• Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
• While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

[davidlygagnon]

We have another prop called dismiss.... I would think we would want to do the same to be consistent?

[aswinshenoy]

hey @davidlygagnon, I didn't get you on this? can you kindly clarify :)

[tanhengyeow]

I think what @davidlygagnon means is that we keep the semantics similar, e.g. change all dismiss... to disable..., similar to the change from dismissable to disableClose.

[interactivellama]

@davidlygagnon What name would you recommend?

[davidlygagnon]

Shouldn't that follow the same pattern as disableClose?

/**
 * If true, Modals cannot be dismissed by clicking outside of modal. If unspecified, defaults to disableClose.
 */
disableCloseOnClickOutside: PropTypes.bool,

[interactivellama]

Got it. Yes, great suggestion.

dismissOnClickOutside is a default true also, it's just not in the default props, since it defers to the dismissible if undefined.

dismissOnClickOutside should become disableCloseOnClickOutside also.

[interactivellama]

@davidlygagnon I've created #1916 to handle other default true prop.

#1916 Created

[davidlygagnon]

Cool thanks!