Fix misuse of ErrorEvent #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another one I'm not sure about bincompat, but definitely good for v2. |
armanbilge
force-pushed
the
error-event
branch
from
2d7f928 to
1a0daec
Compare
|
Agree @armanbilge . Setting to 2.0.0... |
|
Actually on second look there's no bincompat concerns here (all the changes are to an erased type parameter). |
|
Ok LGTM as is, merging. Thanks @unarist for this PR and your patience. This project now has new maintainers, myself and @armanbilge , so we're gonna help out to be responsive to PRs like this going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventforerroreventshttps://www.w3.org/TR/IndexedDB/#fire-error-event
messageproperty in the event. You need to obtain details fromIDBRequest.errorproperty instead, for example.https://developer.mozilla.org/en-US/docs/Web/API/IDBRequest/onerror
ProgressEventfor events exceptreadystatechangehttps://xhr.spec.whatwg.org/#events