Skip to content

Fix misuse of ErrorEvent #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2021
Merged

Fix misuse of ErrorEvent #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
161d44d
Use Event type for IndexedDB errors
unarist Sep 9, 2019
1a0daec
Use ProgressEvent for most XHR events
unarist Sep 9, 2019
3b32eb0
Merge branch 'series/1.x' into error-event
japgolly Aug 20, 2021
24c07e4
Run `sbt prePR`
japgolly Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15128,7 +15128,7 @@ raw/IDBDatabase[JC] def dispatchEvent(evt: Event): Boolean
raw/IDBDatabase[JC] def name: String
raw/IDBDatabase[JC] def objectStoreNames: DOMStringList
raw/IDBDatabase[JC] var onabort: js.Function1[Event, _]
raw/IDBDatabase[JC] var onerror: js.Function1[ErrorEvent, _]
raw/IDBDatabase[JC] var onerror: js.Function1[Event, _]
raw/IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
raw/IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/IDBDatabase[JC] def transaction(storeNames: js.Any, mode: String?): IDBTransaction
Expand Down Expand Up @@ -15175,7 +15175,7 @@ raw/IDBOpenDBRequest[JC] def addEventListener[T <: Event](`type`: String, listen
raw/IDBOpenDBRequest[JC] def dispatchEvent(evt: Event): Boolean
raw/IDBOpenDBRequest[JC] def error: DOMException
raw/IDBOpenDBRequest[JC] var onblocked: js.Function1[Event, _]
raw/IDBOpenDBRequest[JC] var onerror: js.Function1[ErrorEvent, _]
raw/IDBOpenDBRequest[JC] var onerror: js.Function1[Event, _]
raw/IDBOpenDBRequest[JC] var onsuccess: js.Function1[Event, _]
raw/IDBOpenDBRequest[JC] var onupgradeneeded: js.Function1[IDBVersionChangeEvent, _]
raw/IDBOpenDBRequest[JC] def readyState: String
Expand All @@ -15188,7 +15188,7 @@ raw/IDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js
raw/IDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/IDBRequest[JC] def dispatchEvent(evt: Event): Boolean
raw/IDBRequest[JC] def error: DOMException
raw/IDBRequest[JC] var onerror: js.Function1[ErrorEvent, _]
raw/IDBRequest[JC] var onerror: js.Function1[Event, _]
raw/IDBRequest[JC] var onsuccess: js.Function1[Event, _]
raw/IDBRequest[JC] def readyState: String
raw/IDBRequest[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
Expand All @@ -15206,7 +15206,7 @@ raw/IDBTransaction[JC] def mode: String
raw/IDBTransaction[JC] def objectStore(name: String): IDBObjectStore
raw/IDBTransaction[JC] var onabort: js.Function1[Event, _]
raw/IDBTransaction[JC] var oncomplete: js.Function1[Event, _]
raw/IDBTransaction[JC] var onerror: js.Function1[ErrorEvent, _]
raw/IDBTransaction[JC] var onerror: js.Function1[Event, _]
raw/IDBTransaction[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
raw/IDBTransaction[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/IDBTransaction[JO] val READ_ONLY: String
Expand Down Expand Up @@ -24370,14 +24370,14 @@ raw/XMLHttpRequest[JC] def create(): XMLHttpRequest
raw/XMLHttpRequest[JC] def dispatchEvent(evt: Event): Boolean
raw/XMLHttpRequest[JC] def getAllResponseHeaders(): String
raw/XMLHttpRequest[JC] def getResponseHeader(header: String): String
raw/XMLHttpRequest[JC] var onabort: js.Function1[js.Any, _]
raw/XMLHttpRequest[JC] var onerror: js.Function1[ErrorEvent, _]
raw/XMLHttpRequest[JC] var onload: js.Function1[Event, _]
raw/XMLHttpRequest[JC] var onabort: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onerror: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onload: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onloadend: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onloadstart: js.Function1[js.Any, _]
raw/XMLHttpRequest[JC] var onloadstart: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onprogress: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onreadystatechange: js.Function1[Event, _]
raw/XMLHttpRequest[JC] var ontimeout: js.Function1[Event, _]
raw/XMLHttpRequest[JC] var ontimeout: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] def open(method: String, url: String, async: Boolean?, user: String?, password: String?): Unit
raw/XMLHttpRequest[JC] def readyState: Int
raw/XMLHttpRequest[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
Expand All @@ -24402,13 +24402,13 @@ raw/XMLHttpRequest[JO] var UNSENT: Int
raw/XMLHttpRequestEventTarget[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
raw/XMLHttpRequestEventTarget[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/XMLHttpRequestEventTarget[JT] def dispatchEvent(evt: Event): Boolean
raw/XMLHttpRequestEventTarget[JT] var onabort: js.Function1[js.Any, _]
raw/XMLHttpRequestEventTarget[JT] var onerror: js.Function1[ErrorEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onload: js.Function1[js.Any, _]
raw/XMLHttpRequestEventTarget[JT] var onabort: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onerror: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onload: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onloadend: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onloadstart: js.Function1[js.Any, _]
raw/XMLHttpRequestEventTarget[JT] var onloadstart: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onprogress: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var ontimeout: js.Function1[js.Any, _]
raw/XMLHttpRequestEventTarget[JT] var ontimeout: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
raw/XMLHttpRequestEventTarget[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/XMLSerializer[JC] def serializeToString(target: Node): String
Expand Down
28 changes: 14 additions & 14 deletions api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15128,7 +15128,7 @@ raw/IDBDatabase[JC] def dispatchEvent(evt: Event): Boolean
raw/IDBDatabase[JC] def name: String
raw/IDBDatabase[JC] def objectStoreNames: DOMStringList
raw/IDBDatabase[JC] var onabort: js.Function1[Event, _]
raw/IDBDatabase[JC] var onerror: js.Function1[ErrorEvent, _]
raw/IDBDatabase[JC] var onerror: js.Function1[Event, _]
raw/IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
raw/IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/IDBDatabase[JC] def transaction(storeNames: js.Any, mode: String?): IDBTransaction
Expand Down Expand Up @@ -15175,7 +15175,7 @@ raw/IDBOpenDBRequest[JC] def addEventListener[T <: Event](`type`: String, listen
raw/IDBOpenDBRequest[JC] def dispatchEvent(evt: Event): Boolean
raw/IDBOpenDBRequest[JC] def error: DOMException
raw/IDBOpenDBRequest[JC] var onblocked: js.Function1[Event, _]
raw/IDBOpenDBRequest[JC] var onerror: js.Function1[ErrorEvent, _]
raw/IDBOpenDBRequest[JC] var onerror: js.Function1[Event, _]
raw/IDBOpenDBRequest[JC] var onsuccess: js.Function1[Event, _]
raw/IDBOpenDBRequest[JC] var onupgradeneeded: js.Function1[IDBVersionChangeEvent, _]
raw/IDBOpenDBRequest[JC] def readyState: String
Expand All @@ -15188,7 +15188,7 @@ raw/IDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js
raw/IDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/IDBRequest[JC] def dispatchEvent(evt: Event): Boolean
raw/IDBRequest[JC] def error: DOMException
raw/IDBRequest[JC] var onerror: js.Function1[ErrorEvent, _]
raw/IDBRequest[JC] var onerror: js.Function1[Event, _]
raw/IDBRequest[JC] var onsuccess: js.Function1[Event, _]
raw/IDBRequest[JC] def readyState: String
raw/IDBRequest[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
Expand All @@ -15206,7 +15206,7 @@ raw/IDBTransaction[JC] def mode: String
raw/IDBTransaction[JC] def objectStore(name: String): IDBObjectStore
raw/IDBTransaction[JC] var onabort: js.Function1[Event, _]
raw/IDBTransaction[JC] var oncomplete: js.Function1[Event, _]
raw/IDBTransaction[JC] var onerror: js.Function1[ErrorEvent, _]
raw/IDBTransaction[JC] var onerror: js.Function1[Event, _]
raw/IDBTransaction[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
raw/IDBTransaction[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/IDBTransaction[JO] val READ_ONLY: String
Expand Down Expand Up @@ -24370,14 +24370,14 @@ raw/XMLHttpRequest[JC] def create(): XMLHttpRequest
raw/XMLHttpRequest[JC] def dispatchEvent(evt: Event): Boolean
raw/XMLHttpRequest[JC] def getAllResponseHeaders(): String
raw/XMLHttpRequest[JC] def getResponseHeader(header: String): String
raw/XMLHttpRequest[JC] var onabort: js.Function1[js.Any, _]
raw/XMLHttpRequest[JC] var onerror: js.Function1[ErrorEvent, _]
raw/XMLHttpRequest[JC] var onload: js.Function1[Event, _]
raw/XMLHttpRequest[JC] var onabort: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onerror: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onload: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onloadend: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onloadstart: js.Function1[js.Any, _]
raw/XMLHttpRequest[JC] var onloadstart: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onprogress: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] var onreadystatechange: js.Function1[Event, _]
raw/XMLHttpRequest[JC] var ontimeout: js.Function1[Event, _]
raw/XMLHttpRequest[JC] var ontimeout: js.Function1[ProgressEvent, _]
raw/XMLHttpRequest[JC] def open(method: String, url: String, async: Boolean?, user: String?, password: String?): Unit
raw/XMLHttpRequest[JC] def readyState: Int
raw/XMLHttpRequest[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
Expand All @@ -24402,13 +24402,13 @@ raw/XMLHttpRequest[JO] var UNSENT: Int
raw/XMLHttpRequestEventTarget[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
raw/XMLHttpRequestEventTarget[JT] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/XMLHttpRequestEventTarget[JT] def dispatchEvent(evt: Event): Boolean
raw/XMLHttpRequestEventTarget[JT] var onabort: js.Function1[js.Any, _]
raw/XMLHttpRequestEventTarget[JT] var onerror: js.Function1[ErrorEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onload: js.Function1[js.Any, _]
raw/XMLHttpRequestEventTarget[JT] var onabort: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onerror: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onload: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onloadend: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onloadstart: js.Function1[js.Any, _]
raw/XMLHttpRequestEventTarget[JT] var onloadstart: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var onprogress: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] var ontimeout: js.Function1[js.Any, _]
raw/XMLHttpRequestEventTarget[JT] var ontimeout: js.Function1[ProgressEvent, _]
raw/XMLHttpRequestEventTarget[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
raw/XMLHttpRequestEventTarget[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
raw/XMLSerializer[JC] def serializeToString(target: Node): String
Expand Down
6 changes: 3 additions & 3 deletions src/main/scala/org/scalajs/dom/raw/Idb.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ class IDBTransaction extends EventTarget {
*
* MDN
*/
var onerror: js.Function1[ErrorEvent, _] = js.native
var onerror: js.Function1[Event, _] = js.native

/**
* The event handler for the onabort event.
Expand Down Expand Up @@ -613,7 +613,7 @@ class IDBDatabase extends EventTarget {
*
* MDN
*/
var onerror: js.Function1[ErrorEvent, _] = js.native
var onerror: js.Function1[Event, _] = js.native

/**
* Fires when access of the database is aborted.
Expand Down Expand Up @@ -788,7 +788,7 @@ class IDBRequest extends EventTarget {
*
* MDN
*/
var onerror: js.Function1[ErrorEvent, _] = js.native
var onerror: js.Function1[Event, _] = js.native

/**
* The state of the request. Every request starts in the pending state. The state
Expand Down
20 changes: 10 additions & 10 deletions src/main/scala/org/scalajs/dom/raw/lib.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4104,7 +4104,7 @@ class XMLHttpRequest extends EventTarget {
*/
def responseURL: js.UndefOr[String] = js.native

var ontimeout: js.Function1[Event, _] = js.native
var ontimeout: js.Function1[ProgressEvent, _] = js.native

/**
* The response string returned by the HTTP server. Unlike status, this includes the
Expand All @@ -4124,7 +4124,7 @@ class XMLHttpRequest extends EventTarget {
* MDN
*/
var timeout: Double = js.native
var onload: js.Function1[Event, _] = js.native
var onload: js.Function1[ProgressEvent, _] = js.native

/**
* Initializes a request. This method is to be used from JavaScript code; to
Expand Down Expand Up @@ -4187,7 +4187,7 @@ class XMLHttpRequest extends EventTarget {
*/
var withCredentials: Boolean = js.native
var onprogress: js.Function1[ProgressEvent, _] = js.native
var onabort: js.Function1[js.Any, _] = js.native
var onabort: js.Function1[ProgressEvent, _] = js.native

/**
* Can be set to change the response type. Value Data type of response property ""
Expand Down Expand Up @@ -4223,8 +4223,8 @@ class XMLHttpRequest extends EventTarget {
* MDN
*/
var upload: XMLHttpRequestEventTarget = js.native
var onerror: js.Function1[ErrorEvent, _] = js.native
var onloadstart: js.Function1[js.Any, _] = js.native
var onerror: js.Function1[ProgressEvent, _] = js.native
var onloadstart: js.Function1[ProgressEvent, _] = js.native
}

@js.native
Expand Down Expand Up @@ -7325,15 +7325,15 @@ trait XMLHttpRequestEventTarget extends EventTarget {
*
* MDN
*/
var onerror: js.Function1[ErrorEvent, _] = js.native
var onerror: js.Function1[ProgressEvent, _] = js.native

/**
* The function to call when an HTTP request returns after successfully loading
* content.
*
* MDN
*/
var onload: js.Function1[js.Any, _] = js.native
var onload: js.Function1[ProgressEvent, _] = js.native

/**
* A function that is called if the event times out; this only happens if a timeout has
Expand All @@ -7342,21 +7342,21 @@ trait XMLHttpRequestEventTarget extends EventTarget {
*
* MDN
*/
var ontimeout: js.Function1[js.Any, _] = js.native
var ontimeout: js.Function1[ProgressEvent, _] = js.native

/**
* The function to call when a request is aborted.
*
* MDN
*/
var onabort: js.Function1[js.Any, _] = js.native
var onabort: js.Function1[ProgressEvent, _] = js.native

/**
* A function that gets called when the HTTP request first begins loading data.
*
* MDN
*/
var onloadstart: js.Function1[js.Any, _] = js.native
var onloadstart: js.Function1[ProgressEvent, _] = js.native

/**
* A function that is called when the load is completed, even if the request failed.
Expand Down