Add optional signed_audience flag #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarpsvo
commented
Jun 29, 2023
| $httpRequest->setOidcToken($token); | ||
|
|
||
| if ($availableAt > time()) { | ||
| $task->setScheduleTime(new Timestamp(['seconds' => $availableAt])); | ||
| } | ||
|
|
||
| $createdTask = CloudTasksApi::createTask($queueName, $task); |
There was a problem hiding this comment.
This variable was unused.
Tarpsvo
changed the title
|
Added a second fix as well - task name sanitization failed when the task was a closure. See error below: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #113
This fixes issues with some Cloud Run setups where providing the audience to the OidcToken causes the queue runners to receive 401 when trying to POST to Cloud Run instances.