Skip to content

docs: refactor examples of stats/base/dnanmax #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2025
Merged

docs: refactor examples of stats/base/dnanmax #4781

merged 2 commits into from
Jan 16, 2025

Conversation

aayush0325
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • refactors Javascript examples of stats/base/dnanmax to match blas/ext/base/*

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
refactor: refactor examples of
a78481d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 16, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanmax $\color{green}380/380$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}380/380$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jan 16, 2025
@kgryte kgryte changed the title refactor: refactor examples of stats/base/dnanmax docs: refactor examples of stats/base/dnanmax Jan 16, 2025
@kgryte kgryte merged commit ad4a4ce into stdlib-js:develop Jan 16, 2025
12 checks passed
@Planeshifter
Copy link
Member

Planeshifter commented Jan 16, 2025 •
edited
Loading

@kgryte Your edits cause the examples to now generate 80% NaN values (versus 20% before); this seems undesirable.

@kgryte
Copy link
Member

kgryte commented Jan 16, 2025

@Planeshifter Okay. Should be a greater sign, rather than a less than sign. Changed locally.

@kgryte
Copy link
Member

kgryte commented Jan 16, 2025 •
edited
Loading

Update: changed to bernoulli( 0.8 ) < 1. Personally, I am not a fan of omitting the comparison operator (e.g., < 1), as doing so makes it more opaque as to what is returned and expected behavior.

@aayush0325 aayush0325 mentioned this pull request Jan 17, 2025
Merged
1 task
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 18, 2025
@aayush0325 @kgryte @saurabhraghuvanshii
docs: refactor examples of stats/base/dnanmax
807cdb4 
PR-URL: stdlib-js#4781
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025
@aayush0325 @kgryte @saurabhraghuvanshii
docs: refactor examples of stats/base/dnanmax
95a5975 
PR-URL: stdlib-js#4781
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@aayush0325 @kgryte @Neerajpathak07
docs: refactor examples of stats/base/dnanmax
36a024b 
PR-URL: stdlib-js#4781
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@aayush0325 aayush0325 mentioned this pull request Feb 3, 2025
Merged
1 task
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@aayush0325 @kgryte @Vinit-Pandit
docs: refactor examples of stats/base/dnanmax
43174d0 
PR-URL: stdlib-js#4781
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@aayush0325 aayush0325 deleted the refactor-example-dnanmax branch February 16, 2025 08:41
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@aayush0325 @kgryte @ShabiShett07
docs: refactor examples of stats/base/dnanmax
c5e012e 
PR-URL: stdlib-js#4781
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aayush0325 @stdlib-bot @Planeshifter @kgryte