chore: yarn to pnpm #477
chore: yarn to pnpm #477
Conversation
|
.codesandbox/ci.json
Outdated
There was a problem hiding this comment.
I think we don't use codesandbox now, so I removed this file.
.commitlintrc.json
Outdated
There was a problem hiding this comment.
I removed commitlint because I got some conflict between ESLint check and commitlint check.
(I can pass pnpm lint but commitlint angers)
I thought I would solve this conflict, but I decided to remove commitlint.
Because...
Commit message doesn't matter to us because we are merging PRs as squash merge.
And personally linting is unnecessary because anyway, CI will do more comprehensive checks.
I don't want to wait a few seconds for every commit for that too.
| rules: { | ||
| "no-use-before-define": "off", | ||
| }, |
There was a problem hiding this comment.
I couldn't find right fix but after installing pnpm, I got few no-use-before-define errors in Svelte files.
Please tell me some advice if you have a solution🙏
There was a problem hiding this comment.
It seems it was an old eslint v8.0 issue. Just upgrading to 8.10 solves it.
I will make a PR to change the version of eslint.
| @@ -21,7 +21,7 @@ This rule enforces all svelte components to use the same set of languages for th | |||
| ```svelte | |||
| <!-- ✓ GOOD --> | |||
| <script lang="ts"> | |||
| /* eslint svelte/block-lang: {"error", { "script": "ts" }} */ | |||
| /* eslint svelte/block-lang: {"error", { "script": "ts" }} */ | |||
There was a problem hiding this comment.
I use prettier for formatting instead of remark, few formatting occurs but I think these are right formatting.
| | [svelte/require-store-reactive-access](./rules/require-store-reactive-access.md) | disallow to use of the store itself as an operand. Need to use $ prefix or get function. | :wrench: | | ||
| | [svelte/valid-compile](./rules/valid-compile.md) | disallow warnings when compiling. | :star: | | ||
| | [svelte/valid-prop-names-in-kit-pages](./rules/valid-prop-names-in-kit-pages.md) | disallow props other than data or errors in Svelte Kit page components. | | | ||
| | Rule ID | Description | | |
There was a problem hiding this comment.
This is auto-generated table, but I added pnpm run lint-fix:md command for pnpm run update command. So after merge this PR, this table and other auto-generated markdowns will be formatted automatically.
lint-staged.config.js
Outdated
There was a problem hiding this comment.
I removed lint-staged because anyway CI will check everything and I don't want to wait a few seconds in every commit.
simple-git-hooks.js
Outdated
There was a problem hiding this comment.
I removed this because now we don't have git hooks.
| "@sveltejs/adapter-static": "^2.0.0", | ||
| "@sveltejs/kit": "^1.0.0", | ||
| "@sveltejs/adapter-static": "^2.0.2", | ||
| "@sveltejs/kit": "^1.16.3", |
There was a problem hiding this comment.
I updated kit-related deps because some reason I couldn't success build locally.
| "@1stg/stylelint-config": "^5.0.0", | ||
| "@babel/core": "^7.16.0", | ||
| "@babel/eslint-parser": "^7.17.0", | ||
| "@babel/plugin-proposal-function-bind": "^7.16.7", | ||
| "@babel/types": "^7.16.0", | ||
| "@changesets/changelog-github": "^0.4.6", | ||
| "@changesets/cli": "^2.24.2", | ||
| "@changesets/get-release-plan": "^3.0.16", |
There was a problem hiding this comment.
If we want to use some dependency in our code, pnpm requests us to add these deps explicitly. That's why I added a few deps.
| @@ -111,18 +110,18 @@ | |||
| "@types/postcss-safe-parser": "^5.0.1", | |||
| "@types/prismjs": "^1.26.0", | |||
| "@types/stylus": "^0.48.38", | |||
| "@typescript-eslint/eslint-plugin": "^5.45.0", | |||
| "@typescript-eslint/parser": "^5.45.0", | |||
| "@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@4", | |||
There was a problem hiding this comment.
Do we need this deps for now? I got a type error due to this deps, so I removed this.
|
I checked |
close: #474