-
-
Notifications
You must be signed in to change notification settings - Fork 50
chore: yarn to pnpm #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: yarn to pnpm #477
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1bd97c1
chore: install pnpm and just replace yarn to pnpm
baseballyama 737712e
fix: pnpm run build
baseballyama aadd795
fix: pnpm run docs:build
baseballyama e219b16
chore: remove codesandbox
baseballyama 4e7fa23
chore: fix github actions
baseballyama 323985e
chore: use pnpm 7
baseballyama 6b109cf
chore: remove engine-strict
baseballyama 9b637f3
fix: github actions
baseballyama 01402aa
fix: lint error
baseballyama d4584f9
remove commitlint and lint-staged
baseballyama 1e2a83e
update md
baseballyama 7f9d7ce
remove unused deps
baseballyama 575979e
revert md and set prettier for md
baseballyama 016dc30
use cache for prettier
baseballyama 2046658
format markdown after pnpm run update
baseballyama 8d1f525
format
baseballyama d823c5b
revert needless changes
baseballyama 0ce2552
oh now CI failed...
baseballyama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,6 +102,7 @@ dist | |
|
||
## repo | ||
/yarn.lock | ||
/pnpm-lock.yaml | ||
/lib | ||
/.svelte-kit | ||
/.type-coverage | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
package-lock=false | ||
package-lock=false | ||
enable-pre-post-scripts=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
.type-coverage | ||
build | ||
/lib | ||
.npmrc |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find right fix but after installing pnpm, I got few
no-use-before-define
errors in Svelte files.Please tell me some advice if you have a solution🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it was an old eslint v8.0 issue. Just upgrading to 8.10 solves it.
I will make a PR to change the version of eslint.