[lldb] Avoid returning a false positive error when reaching an ObjC b… #10499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
…ase class in SwiftLanguageRuntime::GetIndexOfChildMemberWithName(). My understanding is that the loop should stop once we reach an ObjC base class, because any ivars in the base class will be children of the artificial base class child. rdar://149329166
adrian-prantl
force-pushed
the
149329166
branch
from
9279a16 to
fb48ea1
Compare
|
@swift-ci test |
augusto2112
approved these changes
Apr 17, 2025
| @skipUnlessDarwin | ||
| @swiftTest | ||
| def test(self): | ||
| """Test accessing a static member from a member function""" |
There was a problem hiding this comment.
Test accessing a static member from an ObjC inherited class's member function?
fredriss
approved these changes
Apr 17, 2025
kastiglione
reviewed
Apr 17, 2025
| self, 'break here', lldb.SBFileSpec('main.swift') | ||
| ) | ||
|
|
||
| # dwim-print start by checking whether a member 'A' exists in 'self'. |
There was a problem hiding this comment.
In this case, dwim-print will fallback to expression evaluation, because A isn't a frame variable.
There was a problem hiding this comment.
so this is the same as expression A.shared.
There was a problem hiding this comment.
As far as the result is concerned, yes. But the code path I'm specifically checking here is the failing check for a member 'A' in self, which would have triggered a fallback, which will assert in future versions of the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ase class
in SwiftLanguageRuntime::GetIndexOfChildMemberWithName().
My understanding is that the loop should stop once we reach an ObjC base class, because any ivars in the base class will be children of the artificial base class child.
rdar://149329166