Skip to content

[lldb] Avoid returning a false positive error when reaching an ObjC b… #10499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

[lldb] Avoid returning a false positive error when reaching an ObjC b… #10499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,6 +1059,8 @@ SwiftLanguageRuntime::GetIndexOfChildMemberWithName(
// superclass, and ends on null.
auto *current_tr = tr;
while (current_tr) {
if (llvm::isa<swift::reflection::ObjCClassTypeRef>(current_tr))
break;
auto cti_or_err = reflection_ctx->GetClassInstanceTypeInfo(
*current_tr, &tip, ts.GetDescriptorFinder());
const TypeInfo *cti = nullptr;
Expand Down
3 changes: 3 additions & 0 deletions lldb/test/API/lang/swift/clangimporter/objc_baseclass/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
SWIFT_SOURCES := main.swift

include Makefile.rules
18 changes: 18 additions & 0 deletions lldb/test/API/lang/swift/clangimporter/objc_baseclass/TestSwiftObjCBaseClassMemberLookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import lldb
from lldbsuite.test.lldbtest import *
from lldbsuite.test.decorators import *
import lldbsuite.test.lldbutil as lldbutil

class TestSwiftObjCBaseClassMemberLookup(TestBase):
NO_DEBUG_INFO_TESTCASE = True
@skipUnlessDarwin
@swiftTest
def test(self):
"""Test accessing a static member from a member function"""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test accessing a static member from an ObjC inherited class's member function?

self.build()
lldbutil.run_to_source_breakpoint(
self, 'break here', lldb.SBFileSpec('main.swift')
)

# dwim-print start by checking whether a member 'A' exists in 'self'.
Copy link

@kastiglione kastiglione Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, dwim-print will fallback to expression evaluation, because A isn't a frame variable.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is the same as expression A.shared.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the result is concerned, yes. But the code path I'm specifically checking here is the failing check for a member 'A' in self, which would have triggered a fallback, which will assert in future versions of the test suite.

self.expect("dwim-print A.shared", substrs=["42"])
17 changes: 17 additions & 0 deletions lldb/test/API/lang/swift/clangimporter/objc_baseclass/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import Foundation

class A {
public static var shared = A()
let a = 42
}

class C : NSObject {
var c = 0
func foo() {
print("break here")
c = 1
}
}

C().foo()