[lldb][swift] Fix building with disabled swift support #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the missing ifdefs for code that only compiles/links with an enabled Swift plugin. Also moves a few Swift includes that were embedded in the normal include list to their own section at the end (to prevent automerger issues).
|
@swift-ci test |
|
So it seems building with disabled Swift plugin regressed since I landed it (not surprising since there is no CI job for it), so I set up a CI job for this branch with disabled Swift plugin here which should make sure this is at least compiling: https://ci.teemperor.de/job/swift-main-disabled-swift-buildonly/ #1893 and #1892 are follow ups about getting the test suite green |
adrian-prantl
approved these changes
Oct 1, 2020
kastiglione
approved these changes
Oct 1, 2020
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing ifdefs for code that only compiles/links with an
enabled Swift plugin. Also moves a few Swift includes that were embedded in
the normal include list to their own section at the end (to prevent automerger
issues).