[lldb][swift] Only run Swift Shell tests when Swift support is enabled #1893
Conversation
Teemperor
force-pushed
the
RunSwiftShellTestsOnlyWhenSwiftEnabled
branch
from
fa87cc1 to
56bf89e
Compare
|
@swift-ci test |
| @@ -174,6 +174,12 @@ llvm_canonicalize_cmake_booleans( | |||
| LLVM_ENABLE_SHARED_LIBS | |||
| LLDB_IS_64_BITS) | |||
|
|
|||
| # BEGIN SWIFT | |||
| llvm_canonicalize_cmake_booleans( | |||
There was a problem hiding this comment.
why isn't this conditional on having swift support enabled?
Ah.. this is the code that declares LLDB_ENABLE_SWIFT_SUPPORT? My CMake is not very good.
There was a problem hiding this comment.
The GitHub diff doesn't show enough context above this change to get the context, but this code (and the one above) is 'canonicalizing' the bool variable so that we can use it in the lit.site.cfg.py.in file (it essentially just turns all the different strings CMake interprets as True or False into 1 and 0 respectively so that we can write the value into the Python file). Without that our config file would be turn the line config.lldb_enable_swift = @LLDB_ENABLE_SWIFT_SUPPORT@ to config.lldb_enable_swift = Off (as Off is a legit 'false' value in CMake) and then Python would ask 'what does Off mean'? With this line the config file instead gets config.lldb_enable_swift = 0 which Python understands.
|
@swift-ci test |
Teemperor
force-pushed
the
RunSwiftShellTestsOnlyWhenSwiftEnabled
branch
from
56bf89e to
6413046
Compare
|
@swift-ci test |
|
(Seems like BreakpointSimple.test had a line number hardcoded so the REQUIRES broke it) |
|
@swift-ci test |
Teemperor
force-pushed
the
RunSwiftShellTestsOnlyWhenSwiftEnabled
branch
from
6413046 to
745710b
Compare
Teemperor
changed the title
|
@swift-ci test |
|
swift-ci test platform macos |
|
@swift-ci test platform macos |
Disabling Swift support in LLDB doesn't prevent the test suite from running the Swift tests (which then end up failing instead of being marked as unsupported). This adds a lit feature for Swift and adds the REQUIRES to all Swift tests to mark them as unsupported if Swift is disabled.
Teemperor
force-pushed
the
RunSwiftShellTestsOnlyWhenSwiftEnabled
branch
from
745710b to
779364a
Compare
|
@swift-ci test platform macos |
|
@swift-ci please test |
|
@swift-ci test |
Disabling Swift support in LLDB doesn't prevent the test suite from running
the Swift tests (which then end up failing instead of being marked as
unsupported). This adds a lit feature for Swift and adds the REQUIRES to all
Swift tests to mark them as unsupported if Swift is disabled.