-
Notifications
You must be signed in to change notification settings - Fork 341
Add missing headers #7058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing headers #7058
Conversation
@swift-ci please test |
e2cae77
to
5675b1e
Compare
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That allowed me to clear errors related to SwiftRemoteMirror.cpp
when building Swift for macOS against Xcode 14.2
@swift-ci please test |
CMake version we're using is too old for LLVM:
|
Alright, this gets us through the LLVM build and into Swift build failures due to leaky builds;
(I think this is as good as we're going to get for a bit.) |
5675b1e
to
dea9f91
Compare
@swift-ci please smoke test |
Clang cache uses std::variant, std::unique_ptr, and std::optional. The missing headers are resulting in build failures.
SubtargetFeature.h uses llvm/ADT/bit.h. Reviewed By: compnerd, mib Differential Revision: https://reviews.llvm.org/D154664
dea9f91
to
0723a8f
Compare
Clang CachedDiagnostics uses std::unique_ptr, std::variant, and std::optional, coming from the
memory
,variant
, andoptional
headers respectively. It looks like things shifted a bit so this wasn't building locally on Linux due to missing definitions.llvm subtarget parser SubtargetFeature.h uses
llvm::popcount
, which comes fromllvm/ADT/bit.h
, which was causing build failures locally due to a missingllvm::popcount
declaration.Add missing
optional
include to include/llvm/Support/Format.h